Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated ONCE_INIT #1281

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Remove usage of deprecated ONCE_INIT #1281

merged 1 commit into from
Jul 10, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jul 10, 2019

Motivation

std::sync::ONCE_INIT will be deprecated in Rust 1.38 (rust-lang/rust#61757).
The alternative (Once::new()) seems to have stabilized at the same time as AtomicUsize::new() (rust-lang/rust#61746 (comment)).

Solution

carllerche
carllerche approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit e552562 into tokio-rs:master Jul 10, 2019
@taiki-e taiki-e deleted the remove-deprecated-once-init branch July 11, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @carllerche