-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for laravel 12 #10
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
composer.json (1)
1-77
:⚠️ Potential issueResolve Pipeline Dependency Conflicts
GitHub Actions reported conflicts because some updated dev dependencies expect newer versions oflaravel/framework
andnunomaduro/collision
than currently allowed by the root composer.json. Resolving these conflicts is critical—either update the framework and collision version constraints to allow Laravel 12 (and the newer collision versions) or adjust the dev dependency versions to maintain compatibility with Laravel 10 if backward compatibility is required.🧰 Tools
🪛 GitHub Actions: Tests
[error] 1-1: Conflict: pestphp/pest-plugin-laravel v3.1.0 requires laravel/framework ^11.39.1|^12.0.0, but your root composer.json requires laravel/framework 10.*.
[error] 1-1: Conflict: pestphp/pest v3.7 requires nunomaduro/collision ^8.5.0, but your root composer.json requires nunomaduro/collision 7.*.
🧹 Nitpick comments (1)
composer.json (1)
55-57
: PHP & Filament Dependency Updates: Verify Constraint Syntax
The PHP version requirement now reads"8.2|^8.3|^8.4"
. Please double-check that this format accurately captures the intended version range. Typically, constraints like">=8.2"
or similar are used for clarity. The update to"filament/filament": "^3.3"
appears correct for supporting Laravel 12 features.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
composer.json
(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests
composer.json
[error] 1-1: Conflict: pestphp/pest-plugin-laravel v3.1.0 requires laravel/framework ^11.39.1|^12.0.0, but your root composer.json requires laravel/framework 10.*.
[error] 1-1: Conflict: pestphp/pest v3.7 requires nunomaduro/collision ^8.5.0, but your root composer.json requires nunomaduro/collision 7.*.
🔇 Additional comments (1)
composer.json (1)
75-75
: Version Bump Confirmation
The package version is updated to"2.3.3"
, which correctly reflects the cumulative updates. Please ensure that this change is reflected in the changelog and other documentation as needed.
"laravel/pint": "^1.21", | ||
"livewire/livewire": "^2.10|^3.0", | ||
"nunomaduro/larastan": "^2.9", | ||
"orchestra/testbench": "^9.5", | ||
"pestphp/pest": "^2.36", | ||
"pestphp/pest-plugin-laravel": "^2.4", | ||
"pestphp/pest-plugin-livewire": "^2.1", | ||
"nunomaduro/larastan": "^3.1", | ||
"orchestra/testbench": "^10.0", | ||
"pestphp/pest": "^3.7", | ||
"pestphp/pest-plugin-laravel": "^3.1", | ||
"pestphp/pest-plugin-livewire": "^3.0", | ||
"phpstan/extension-installer": "^1.4", | ||
"phpstan/phpstan-deprecation-rules": "^1.2", | ||
"phpstan/phpstan-phpunit": "^1.4" | ||
"phpstan/phpstan-deprecation-rules": "^2.0", | ||
"phpstan/phpstan-phpunit": "^2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev Dependency Upgrades & Framework Compatibility Concerns
The updates to dev dependencies (e.g., "laravel/pint": "^1.21"
, "nunomaduro/larastan": "^3.1"
, "orchestra/testbench": "^10.0"
, "pestphp/pest": "^3.7"
, "pestphp/pest-plugin-laravel": "^3.1"
, "phpstan/phpstan-deprecation-rules": "^2.0"
, and "phpstan/phpstan-phpunit": "^2.0"
) are consistent with enabling support for Laravel 12. However, note the following conflicts indicated by the pipeline failures:
- pestphp/pest-plugin-laravel v3.1.0 demands
laravel/framework
version^11.39.1|^12.0.0
, yet the root (or main project) composer.json currently restricts it to10.*
. - pestphp/pest v3.7 requires
nunomaduro/collision
version^8.5.0
, conflicting with a requirement of7.*
from the root composer.json.
To fully add support for Laravel 12 as intended by this PR, please update the root framework constraints (and related packages like nunomaduro/collision) accordingly.
Summary by CodeRabbit