Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for laravel 12 #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for laravel 12 #10

wants to merge 2 commits into from

Conversation

megoxv
Copy link
Member

@megoxv megoxv commented Feb 26, 2025

Summary by CodeRabbit

  • Chores
    • Updated PHP version support to include newer releases.
    • Upgraded runtime and development dependencies for enhanced stability and performance.
    • Incremented the package version to reflect these improvements.

Copy link

coderabbitai bot commented Feb 26, 2025

Walkthrough

The composer.json file has been updated to refine dependency requirements and version constraints. The PHP requirement was changed from supporting PHP 8.1 and 8.2 to targeting PHP 8.2 and newer releases, and several package versions have been incremented. Notably, the filament/filament package and various development packages (including Laravel Pint, Larastan, Orchestra Testbench, Pest packages, and PHPStan tools) received newer constraints. Additionally, the overall package version was bumped from 2.3.0 to 2.3.3. These modifications adjust the environment and development tooling requirements for the project.

Changes

File Change Summary
composer.json - PHP Version: Updated from `"^8.1

Poem

I’m a little rabbit with a joyful beat,
Hopping through changes so light and neat.
Dependencies updated, versions all align,
Code moves forward in a fresh design.
With a twitch of my nose, I cheer and say,
“Onward we hop to a brighter day!”
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
composer.json (1)

1-77: ⚠️ Potential issue

Resolve Pipeline Dependency Conflicts
GitHub Actions reported conflicts because some updated dev dependencies expect newer versions of laravel/framework and nunomaduro/collision than currently allowed by the root composer.json. Resolving these conflicts is critical—either update the framework and collision version constraints to allow Laravel 12 (and the newer collision versions) or adjust the dev dependency versions to maintain compatibility with Laravel 10 if backward compatibility is required.

🧰 Tools
🪛 GitHub Actions: Tests

[error] 1-1: Conflict: pestphp/pest-plugin-laravel v3.1.0 requires laravel/framework ^11.39.1|^12.0.0, but your root composer.json requires laravel/framework 10.*.


[error] 1-1: Conflict: pestphp/pest v3.7 requires nunomaduro/collision ^8.5.0, but your root composer.json requires nunomaduro/collision 7.*.

🧹 Nitpick comments (1)
composer.json (1)

55-57: PHP & Filament Dependency Updates: Verify Constraint Syntax
The PHP version requirement now reads "8.2|^8.3|^8.4". Please double-check that this format accurately captures the intended version range. Typically, constraints like ">=8.2" or similar are used for clarity. The update to "filament/filament": "^3.3" appears correct for supporting Laravel 12 features.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99bd401 and c53ab87.

📒 Files selected for processing (1)
  • composer.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests
composer.json

[error] 1-1: Conflict: pestphp/pest-plugin-laravel v3.1.0 requires laravel/framework ^11.39.1|^12.0.0, but your root composer.json requires laravel/framework 10.*.


[error] 1-1: Conflict: pestphp/pest v3.7 requires nunomaduro/collision ^8.5.0, but your root composer.json requires nunomaduro/collision 7.*.

🔇 Additional comments (1)
composer.json (1)

75-75: Version Bump Confirmation
The package version is updated to "2.3.3", which correctly reflects the cumulative updates. Please ensure that this change is reflected in the changelog and other documentation as needed.

Comment on lines +64 to +73
"laravel/pint": "^1.21",
"livewire/livewire": "^2.10|^3.0",
"nunomaduro/larastan": "^2.9",
"orchestra/testbench": "^9.5",
"pestphp/pest": "^2.36",
"pestphp/pest-plugin-laravel": "^2.4",
"pestphp/pest-plugin-livewire": "^2.1",
"nunomaduro/larastan": "^3.1",
"orchestra/testbench": "^10.0",
"pestphp/pest": "^3.7",
"pestphp/pest-plugin-laravel": "^3.1",
"pestphp/pest-plugin-livewire": "^3.0",
"phpstan/extension-installer": "^1.4",
"phpstan/phpstan-deprecation-rules": "^1.2",
"phpstan/phpstan-phpunit": "^1.4"
"phpstan/phpstan-deprecation-rules": "^2.0",
"phpstan/phpstan-phpunit": "^2.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Dev Dependency Upgrades & Framework Compatibility Concerns
The updates to dev dependencies (e.g., "laravel/pint": "^1.21", "nunomaduro/larastan": "^3.1", "orchestra/testbench": "^10.0", "pestphp/pest": "^3.7", "pestphp/pest-plugin-laravel": "^3.1", "phpstan/phpstan-deprecation-rules": "^2.0", and "phpstan/phpstan-phpunit": "^2.0") are consistent with enabling support for Laravel 12. However, note the following conflicts indicated by the pipeline failures:

  • pestphp/pest-plugin-laravel v3.1.0 demands laravel/framework version ^11.39.1|^12.0.0, yet the root (or main project) composer.json currently restricts it to 10.*.
  • pestphp/pest v3.7 requires nunomaduro/collision version ^8.5.0, conflicting with a requirement of 7.* from the root composer.json.

To fully add support for Laravel 12 as intended by this PR, please update the root framework constraints (and related packages like nunomaduro/collision) accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant