Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last release build v0.8.8 breaks the app #918

Closed
mravinale opened this issue Sep 4, 2015 · 11 comments
Closed

last release build v0.8.8 breaks the app #918

mravinale opened this issue Sep 4, 2015 · 11 comments

Comments

@mravinale
Copy link

Version:
https://github.com/tombatossals/angular-leaflet-directive/releases/tag/v0.8.8

JsFidle:
using the V0.8.8 http://jsfiddle.net/mravinale/rjnf0g78/

Error detail:

Error: [$injector:modulerr] Failed to instantiate module billboarderApp due to:
    Error: [$injector:modulerr] Failed to instantiate module leaflet-directive due to:
    Error: [$injector:modulerr] Failed to instantiate module nemLogging due to:
    Error: [$injector:nomod] Module 'nemLogging' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
@mravinale
Copy link
Author

fixed for now going back to the last version, be careful

@nmccready
Copy link
Contributor

@mravinale look at the dependency list in bower the logger is now a dependency. If you use https://github.com/ck86/main-bower-files to load your deps you'll never have this problem

@nmccready
Copy link
Contributor

also the error is flat out in there Module 'nemLogging' is not available!

@nmccready
Copy link
Contributor

#829

@max-degterev
Copy link

some people use npm over bower for simplicity's sake. can we fix this somehow?

@max-degterev
Copy link

p.s. good god, angular-simple-logger depends on other modules as well, I wonder how long would I have to spend to load whole deps tree for this bugger
screen shot 2015-10-02 at 5 27 51 pm

@nmccready
Copy link
Contributor

People make mistakes and I am fixing good god, you don't have to be an db. You could also make a PR on the logger as well.

@elesdoar
Copy link
Contributor

elesdoar commented Oct 2, 2015

@suprMax Sorry, you could fork the project and contribute, or only use a previous version, don't make things more complicated. It's open source, all we contribute, not demand.

@max-degterev
Copy link

I mean no disrespect and appreciate the work you've done. Sorry if you've taken this personally.

No offense guys, just would be cool to have it working out of the box if it's published to npm, that's all.

@nmccready
Copy link
Contributor

Thanks for the reply, and please remember tone is everything. I myself need to watch this from time to time. But when it is negative it is very very demotivating to continue working on these projects (when it is free).

There is actually a conversation going on now on leaflet 1.0 on becoming npm centric because leaflet itself wants out bower. Currently jspm, npm and keeping bower are on the table. #851

@nmccready
Copy link
Contributor

Feel free to chime in and help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants