Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular-leaflet-directive 0.8.8 requires nemLogging #920

Closed
rpadovani opened this issue Sep 5, 2015 · 7 comments
Closed

angular-leaflet-directive 0.8.8 requires nemLogging #920

rpadovani opened this issue Sep 5, 2015 · 7 comments

Comments

@rpadovani
Copy link

If I update the module to version 0.8.8 it fails to start with this error:

Error: [$injector:modulerr] Failed to instantiate module demoapp due to:
[$injector:modulerr] Failed to instantiate module leaflet-directive due to:
[$injector:modulerr] Failed to instantiate module nemLogging due to:
[$injector:nomod] Module 'nemLogging' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
http://errors.angularjs.org/1.4.5/$injector/nomod?p0=nemLogging
minErr/<@file:///home/rpadovani/Archon/leaflet/bug-linestring/bower_components/angular/angular.js:68:12
module/<@file:///home/rpadovani/Archon/leaflet/bug-linestring/bower_components/angular/angular.js:1983:1
ensure@file:///home/rpadovani/Archon/leaflet/bug-linestring/bower_components/angular/angular.js:1907:38
module@file:///home/rpadovani/Archon/leaflet/bug-linestring/bower_components/angular/angular.js:1981:1

I've no idea what nemLogging is supposed to be.

@simison
Copy link
Contributor

simison commented Sep 5, 2015

Duplicate of #918

As per #829 you need to include angular-simple-logger into your project now.

@rpadovani
Copy link
Author

I have "angular-simple-logger": "~0.0.1", in my bower.json, it doesn't work.

@nmccready
Copy link
Contributor

You have to load the script prior. There are tools out there to do this for you or you need to move it or direct the html to the correct location.

@iammichiel
Copy link

Too bad, this library doesn't use semantic versionning... Introducing a BC break like this broke a lot of things and semver would have prevented breaking our builds.

@simison
Copy link
Contributor

simison commented Oct 6, 2015

@iammichiel yup, you're right. #829

At least 5d08f85

@jtroe
Copy link
Contributor

jtroe commented Oct 7, 2015

It would probably be best if we update the gh-pages so the examples at http://tombatossals.github.io/angular-leaflet-directive reflect this. The examples using 0.8.6 threw me off too.

@nmccready
Copy link
Contributor

See #984 I will start digging into the gh-pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants