issue 829 independent logging #915
Merged
+366
−286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3018,6 +3027,10 @@ angular.module("leaflet-directive") | |||
| }; | |||
| }); | |||
|
|
|||
| angular.module("leaflet-directive").service('leafletLogger', ["nemSimpleLogger", function(nemSimpleLogger) { | |||
| return nemSimpleLogger.spawn(); | |||
There was a problem hiding this comment.
Create our own instance of an independent logger where leaflet-directive's logging domain is separate of everything else. "leafletLogger" is then used everywhere else where $log used to be.
|
@tombatossals @elesdoar @jessertaylor |
|
ping? |
…ue_829/simpleLogger
|
I was hoping to get some feedback, but it's been two days. Merging. |
nmccready
added a commit
that referenced
this pull request
Sep 4, 2015
…eLogger issue 829 independent logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizing a independent logger I wrote for ui-gmap which has been ported to angular-simple-logger on github