fix: warn user about bad pattern paths before skipping step git #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standards checklist:
CONTRIBUTING.md
cargo build
)cargo fmt
)cargo clippy
)cargo test
)If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.
We should warn the user about the bad pattern before skipping the step git:
I think besides
Skipped
, we should define another stateNotFound
, when a step's binary is not found in$PATH
, we useNotFound
to skip this step instead ofSkipped
. For the case where the binary is found but some conditions are not satisfied during execution (e.g., for git step, no repo is found, like the case described in this PR), we useSkipped
.And for a
Skipped
step, a separator should be printed and a warning should be given to the user telling the user why this step was skipped. For aNotFound
step, we don't need to print a separator as users don't use it at all.