Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore containers to pull #613

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

JakobFels
Copy link
Contributor

What

Add a new option to skip containers to pull. This is my first time writing rust, so feedback is appreciated.

Why

Tools like rancher-desktop add containers that cannot be pulled, resulting in errors.
This option allows to skip containers like these.

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

@JakobFels
Copy link
Contributor Author

Seems like containers.rs had crlf line endings, if needed I can revert the conversion to lf

@SteveLauC
Copy link
Member

Seems like containers.rs had crlf line endings, if needed I can revert the conversion to lf

Yeah, that would be good

@JakobFels JakobFels force-pushed the ignore-container-option branch 2 times, most recently from 62ff759 to 1984265 Compare November 24, 2023 08:16
@JakobFels
Copy link
Contributor Author

I restored the original line endings.

@SteveLauC
Copy link
Member

Other changes LGTM, thanks! :)

@JakobFels JakobFels force-pushed the ignore-container-option branch from 1984265 to f1e1d2a Compare November 24, 2023 08:30
@JakobFels JakobFels force-pushed the ignore-container-option branch from f1e1d2a to e042d9b Compare November 24, 2023 08:42
@SteveLauC SteveLauC merged commit a15e674 into topgrade-rs:main Nov 24, 2023
@SteveLauC
Copy link
Member

SteveLauC commented Nov 24, 2023

Thanks! And congratulations on your first contribution to Topgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants