Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devskim.yml to enable GitHub code scanning for this repository #700

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

niStee
Copy link
Contributor

@niStee niStee commented Feb 18, 2024

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@SteveLauC
Copy link
Member

This seems to be a nice feature to add, but reports warning even to TODOs:

image

Is there a rule that we can use to stop it from doing this?

@niStee
Copy link
Contributor Author

niStee commented Feb 23, 2024

This seems to be a nice feature to add, but reports warning even to TODOs:

image

Is there a rule that we can use to stop it from doing this?

I have not yet found a way to not check for TODOs, but you can either dismiss them or define them as not severe enough to cause a pull-request to fail a review.

@SteveLauC
Copy link
Member

but you can either dismiss them or define them as not severe enough to cause a pull-request to fail a review.

I have dismissed those alerts.

Would you like to enable this check for PRs by not limiting the branches to main?

@niStee niStee changed the title Create devskim.yml Create devskim.yml to enable GitHub code scanning for this repository Feb 24, 2024
Changed the workflow to trigger on pull requests to all branches and on push events to the main branch.
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@SteveLauC SteveLauC merged commit eea952f into topgrade-rs:main Feb 24, 2024
11 checks passed
@niStee niStee deleted the feature/devskimIntegration branch February 24, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants