-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't run reboot with sudo on Linux with systemd #866
feat: don't run reboot with sudo on Linux with systemd #866
Conversation
2dc15d8
to
232f056
Compare
This did not work for me. I got a crash before the reboot phase |
Thanks for testing it! This crash is not related to this PR, it is caused by the waydroid step, please disable it and topgrade again : $ ./topgrade --disable waydroid |
Regarding that waydroid issue, could you please provide the ouput of: $ waydroid status |
here's the waydroid status. makes sense disabling waydroid let the update work but i was never prompted for a reboot to try it. output attached i'm running the topgrade file as an exe as my own user, i assume this is good enough? |
that worked =) rebooted successfully! |
Can you execute |
sure. here's the error
i haven't used waydroid, only installed it in the possibility of using it in the future ...- but considering it isnt working i might just remove it from bazzite and simplify the issue |
Thanks for providing the output, I have created an issue in Topgrade for this: #869 |
What does this PR do
Based on the discussion in #861, on Linux with systemd,
reboot
can be invoked withoutsudo
, this PR implements it.Closes #861.
Standards checklist
CONTRIBUTING.md
For new steps
--dry-run
option works with this step--yes
option works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.