Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin toolchain to MSRV(1.76) #900

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Sep 4, 2024

What does this PR do

  1. Pin the toolchain to 1.76.0
  2. For our CI, remove the dtolnay/rust-toolchain action as it is no longer needed:
    1. GH CI provides rustup by default
    2. We have the toolchain specified in rust-toolchain.toml
    3. Thus, cargo xxx will download the toolchain automatically

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC SteveLauC merged commit 05b1a56 into topgrade-rs:main Sep 4, 2024
11 checks passed
@SteveLauC SteveLauC deleted the chore/MSRV branch September 4, 2024 13:40
@SteveLauC SteveLauC mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant