Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in exit_status #934

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

aveyrenc
Copy link
Contributor

@aveyrenc aveyrenc commented Oct 7, 2024

What does this PR do

Fix a typo in exit_status.

Maybe fixes issue #930

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

Output of failing step before patch:

── 21:46:00 - Brew ─────────────────────────────────────────────────────────────
Brew failed: 
   0: Command failed: `brew update`
   1: `brew` failed: %{exit_satus}

Location:
   src/steps/os/unix.rs:335
Retry? (y)es/(N)o/(s)hell/(q)uit

After patch:

── 21:44:47 - Brew ─────────────────────────────────────────────────────────────
Brew failed: 
   0: Command failed: `brew update`
   1: `brew` failed: exit status: 1

Location:
   src/steps/os/unix.rs:335
Retry? (y)es/(N)o/(s)hell/(q)uit

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I am working on an i18n checker, but checking arguments has not been implemented yet. 😪

@SteveLauC SteveLauC merged commit 9767e41 into topgrade-rs:main Oct 8, 2024
12 checks passed
@SteveLauC SteveLauC mentioned this pull request Oct 8, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants