npm-release: @trezor/connect 9.5.2 #17651
Conversation
|
trezor-ci
requested review from
mroz22,
marekrjpolak,
szymonlesisz,
karliatto,
martykan and
tomasklim
as code owners
|
🚀 Expo preview is ready!
|
WalkthroughThe update transitions multiple packages from beta releases to stable releases. Versions in package manifest files and changelogs have been updated consistently across various modules, including Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
packages/connect/package.json (1)
3-3: Removal of Beta Identifier.
The version for@trezor/connecthas been updated to"9.5.2", marking its move to a stable release. It is advisable to verify that any beta-specific configurations or references (e.g., in documentation or other configuration files) have been appropriately updated.packages/connect-web/package.json (1)
3-3: Removal of Beta Identifier Confirmed.
The package@trezor/connect-webnow uses version"9.5.2", removing the previous beta flag. Please ensure that all internal references—including those in files such astrezor-usb-permissions.js—correctly reflect this stable version update.packages/utils/CHANGELOG.md (1)
3-6: Changelog Entry – Typo & Beta Identifier Consistency
There is a minor typographical error on line 5: "refactorign" should be corrected to "refactoring". Additionally, the changelog for version "9.3.2" still references beta labels (e.g., "9.3.2-beta.2" and "9.5.2-beta.1"). Please confirm whether these beta identifiers should be updated to reflect the stable release explicitly or are intended to document the prerelease steps.packages/blockchain-link-types/CHANGELOG.md (1)
1-6: Changelog Entry for Version 1.3.2 – Beta Label Review
The new version entry "# 1.3.2" is added correctly. However, the listed items still reference beta versions (e.g., "1.3.2-beta.2" and "9.5.2-beta.1"). Please verify if these should be revised for clarity in the context of a stable release or if they are meant to document the prerelease phase.packages/device-utils/CHANGELOG.md (4)
6-6: Typo in Commit MessageIn the commit message:
chore: more refactorign to remove connect from components (3736dec0a5)consider correcting "refactorign" to "refactoring" for clarity.
11-11: Fix Typographical ErrorsIn the commit message:
chore: remove glboal nx/workspace link scripts (it shall be run only globally) + resolve ugly igonores for devDependencies in import/no-extraneous-dependencies (abb41f8033)please change "glboal" to "global" and "igonores" to "ignores".
12-12: Correct Typo in Commit MessageIn the commit message:
chore(device-utils): acccept only PartialDevice as param (4764484da9)please correct "acccept" to "accept".
34-34: Correct Spelling in Commit MessageIn the commit message:
chore: remove some unecessary build:lib (0a5d8267c4)please change "unecessary" to "unnecessary".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (33)
packages/analytics/CHANGELOG.md(1 hunks)packages/analytics/package.json(1 hunks)packages/blockchain-link-types/CHANGELOG.md(1 hunks)packages/blockchain-link-types/package.json(1 hunks)packages/blockchain-link-utils/CHANGELOG.md(1 hunks)packages/blockchain-link-utils/package.json(1 hunks)packages/blockchain-link/CHANGELOG.md(1 hunks)packages/blockchain-link/package.json(1 hunks)packages/connect-analytics/CHANGELOG.md(1 hunks)packages/connect-analytics/package.json(1 hunks)packages/connect-common/CHANGELOG.md(1 hunks)packages/connect-common/package.json(1 hunks)packages/connect-web/package.json(1 hunks)packages/connect-web/src/webextension/trezor-usb-permissions.js(1 hunks)packages/connect-webextension/package.json(1 hunks)packages/connect/CHANGELOG.md(1 hunks)packages/connect/README.md(1 hunks)packages/connect/package.json(1 hunks)packages/connect/src/data/version.ts(1 hunks)packages/device-utils/CHANGELOG.md(1 hunks)packages/device-utils/package.json(2 hunks)packages/protobuf/CHANGELOG.md(1 hunks)packages/protobuf/package.json(1 hunks)packages/protocol/CHANGELOG.md(1 hunks)packages/protocol/package.json(1 hunks)packages/transport/CHANGELOG.md(1 hunks)packages/transport/package.json(1 hunks)packages/utils/CHANGELOG.md(1 hunks)packages/utils/package.json(1 hunks)packages/utxo-lib/CHANGELOG.md(1 hunks)packages/utxo-lib/package.json(1 hunks)packages/websocket-client/CHANGELOG.md(1 hunks)packages/websocket-client/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
packages/websocket-client/package.json (1)
Learnt from: szymonlesisz
PR: trezor/trezor-suite#15797
File: packages/trezor-user-env-link/src/websocket-client.ts:82-91
Timestamp: 2025-03-12T13:05:17.357Z
Learning: The @trezor/trezor-user-env-link is an internal package used within the workspace and doesn't require public version management or changelog documentation.
⏰ Context from checks skipped due to timeout of 90000ms (14)
- GitHub Check: PR-check / node-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
- GitHub Check: PR-check / web-override init-api-flaky
- GitHub Check: PR-check / node-override init-api-flaky
- GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
- GitHub Check: build-deploy
- GitHub Check: build-deploy
- GitHub Check: EAS Update
- GitHub Check: transport-e2e-test
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: prepare_android_test_app
- GitHub Check: test
- GitHub Check: build-web
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (60)
packages/utxo-lib/CHANGELOG.md (2)
1-4: Stable Release Update Logged Correctly.
The changelog now introduces version 2.3.2 and removes the beta prerelease entry (npm-prerelease: @trezor/utxo-lib 2.3.2-beta.1 (d2bcdc8348)). This reflects the intended transition from a beta to a stable release. Please double-check that this update is in sync with the corresponding version change in the package manifest.
5-9: Historical Entries Adjusted Consistently.
The removal of the beta prerelease line for version 2.3.1 (i.e.npm-prerelease: @trezor/utxo-lib 2.3.1-beta.1 (d1159a83e5)) and the related fix entry appears intentional to align with the stable release strategy. Ensure that the changelog modifications accurately reflect the production-ready state.packages/analytics/package.json (1)
2-3: Version Bump from Beta to Stable.
The version update from"1.3.2-beta.1"to"1.3.2"correctly signals the transition to a stable release. All other metadata remains unchanged, indicating consistency with the overall release process.packages/utxo-lib/package.json (1)
1-4: Consistent Version Upgrade in Package Manifest.
Updating the"version"field to"2.3.2"(from the beta version) is aligned with the latest changelog entry. Please verify that all dependent components referencing this package are aware of the version bump.packages/connect-common/package.json (1)
1-4: Transition to Stable Version for Connect-Common.
The change from"0.3.2-beta.2"to"0.3.2"is correctly applied, reflecting the stabilized state of the package. All accompanying repository and dependency details appear appropriate.packages/protocol/package.json (1)
1-4: Stabilizing Protocol Version Update.
The upgrade from"1.2.4-beta.2"to"1.2.4"is implemented correctly. This change should now be propagated to any modules relying on the protocol package. A quick verification of downstream dependency compatibility is recommended.packages/blockchain-link/package.json (1)
3-3: Version Bump to Stable Release Confirmed.
The version for@trezor/blockchain-linkhas been updated to"2.4.2", reflecting the transition from a beta release to a stable release. Please ensure that any related changelog entries or dependency references are updated accordingly.packages/blockchain-link-types/package.json (1)
3-3: Stable Release Version Update Confirmed.
The package@trezor/blockchain-link-typesnow shows the version"1.3.2", effectively removing the beta identifier. This change aligns with our coordinated release process across the ecosystem.packages/protobuf/package.json (1)
3-3: Stable Version Bump Verified.
The version for@trezor/protobufhas been updated to"1.3.2"from its beta version, ensuring consistency with the other packages in this release.packages/transport/package.json (1)
3-3: Stable Release Version Update for TransportThe version update from a beta identifier to a stable release (
"1.4.2-beta.2"→"1.4.2") is correctly applied. Please ensure that the corresponding changelog entry is updated and that any related dependency references are consistent across the project.packages/connect-webextension/package.json (1)
3-3: Stable Release Version Bump for Connect-WebextensionThe version transition from beta (
9.5.2-beta.2) to a stable release (9.5.2) has been performed correctly. Confirm that the changelog and any documentation are updated accordingly to reflect this change.packages/blockchain-link-utils/package.json (1)
3-3: Stable Version Update for Blockchain Link UtilsUpdating the package version from
"1.3.2-beta.2"to"1.3.2"is consistent with the overall release objectives. Please double-check that the changelog notes this change and that any internal or external references to this version are updated.packages/utils/package.json (1)
3-3: Stable Release Update for Utils PackageThe version bump from
"9.3.2-beta.2"to"9.3.2"correctly promotes the package to a stable release. Verify that all dependency references within the suite have been adjusted as needed and that the changelog reflects the updated release state.packages/websocket-client/package.json (1)
3-3: Stable Release Version Update for Websocket ClientChanging the version from
"1.1.2-beta.1"to"1.1.2"is properly aligned with the stable release process. Please ensure that the associated documentation and changelog entries are in sync with this update and that there are no lingering references to the beta version in internal tooling.packages/connect/README.md (1)
3-3: API Version Update Confirmation
The API version is updated from the beta identifier to the stable version "9.5.2". Ensure that any further references to the version in the documentation (such as in links or examples) remain consistent with this change.packages/connect-analytics/package.json (1)
3-3: Version Bump Verification
The version for@trezor/connect-analyticshas been correctly updated from a beta version to the stable release "1.3.1". No further action is needed.packages/device-utils/package.json (2)
3-3: Stable Version Update Confirmation
The version is updated from "1.0.1-beta.1" to "1.0.1", which correctly reflects the transition from beta to a stable release.
21-24: Addition of Development Dependency
ThedevDependenciessection now includes"tsx": "^4.19.3", which should support the updated build and prepublish scripts. Please ensure that this version is compatible with your existing build tooling.packages/blockchain-link-utils/CHANGELOG.md (1)
1-5: LGTM: Changelog entry for version 1.3.2 looks goodThe new version entry correctly documents the transition from beta to stable release with appropriate references to previous beta releases and fixes.
packages/connect-web/src/webextension/trezor-usb-permissions.js (1)
1-1: LGTM: Version updated from beta to stable releaseThe version has been correctly updated from '9.5.2-beta.2' to '9.5.2', which will cause
isBetato evaluate tofalseand use the stable URL formathttps://connect.trezor.io/9/.packages/connect/src/data/version.ts (1)
1-1: LGTM: Version updated from beta to stable releaseThe version constant has been correctly updated from '9.5.2-beta.2' to '9.5.2', which matches the updates in related packages and follows the PR objective of transitioning to stable releases.
packages/analytics/CHANGELOG.md (1)
1-3: LGTM: Changelog entry for version 1.3.2 looks goodThe new version entry correctly documents the transition from beta to stable release with appropriate reference to the beta version.
packages/websocket-client/CHANGELOG.md (3)
1-4: Version Bump to Stable Release:
The version header now shows “# 1.1.2” without any beta identifier, which indicates the package has moved from prerelease to a stable version. This is consistent with the overall aim of removing beta tags for a stable npm release.
7-9: Cleanup of Previous Beta Entries:
The removal of the beta prerelease entry (1.1.1-beta.1) and associated fix note now helps streamline the changelog. Please double-check that all references to the outdated beta entries have been removed consistently.
12-16: Historical Entry Retention for Older Versions:
The entries for version 1.1.0 (including the beta notes for1.1.0-beta.1and1.0.1-beta.1) along with the initial package creation note are retained. Make sure these historical details accurately reflect the past state and that the document remains clear for future reference.packages/connect-analytics/CHANGELOG.md (3)
1-5: Transition from Beta to Stable for Connect-Analytics:
For the new version header “# 1.3.1,” the removal of the beta prerelease entry (1.3.1-beta.2) and the related beta entry for @trezor/connect (9.5.2-beta.1) is in line with the strategy to mark these releases as stable. Ensure that the final changelog entry elsewhere reflects the stable release details consistently.
8-10: Historical Beta Cleanup for Version 1.3.0:
The removal of the beta prerelease line for version 1.2.5 (as well as the associated fix entry) helps maintain a clean history. Verify that any critical fix information is documented in the appropriate stable release notes if needed.
12-14: Clean‐up for the 1.2.4 Entry:
Eliminating the beta tag from version 1.2.4 keeps the document consistent with the rest of the release notes. Please confirm that no lingering beta references remain in connected documentation.packages/protobuf/CHANGELOG.md (7)
1-9: Version 1.3.2 Update for Protobuf:
In the 1.3.2 section, the removal of the beta prerelease (1.3.2-beta.2) along with the beta reference to @trezor/connect (9.5.2-beta.1) is clearly documented. New entries such as the fix for the DeviceModelInternal read patch, the exclusion of “nostr,” and the feature to load definitions are now part of this version. Please verify that these changes have been tested and that the related migration (e.g. moving DeviceModelInternal to device-utils) is fully integrated.
10-14: Version 1.3.1 Cleanup:
The 1.3.1 section shows the removal of the beta prerelease (1.3.1-beta.1) and includes a fix for the package script. This appears to be a minor cleanup meant to ensure consistency across releases.
15-26: Updates for Version 1.3.0:
This block removes multiple beta prerelease entries (for versions 1.3.0 and 1.2.7) and clears out transport-related changes that were reverted or modified. It also includes ESLint chore updates and a new definition update for “ResetDevice.entropy_check” plus a note on introducing an internal model for non‐standard devices. The collection of changes is quite comprehensive; please ensure that the integration between protocol and transport remains seamless.
27-30: Version 1.2.6 Notice:
The removal of the beta prerelease marker for version 1.2.6 is a straightforward cleanup.
31-35: Updates for Version 1.2.5:
The beta prerelease for version 1.2.5 is removed and an update to the protobuf definitions (adding a display type enum) has been recorded. This should contribute to clearer documentation for how the package handles display types.
36-39: Version 1.2.4 Revision:
With the removal of the beta prerelease for version 1.2.4, please confirm that the changes are harmonized with the overall trend of stable releases….
40-58: Comprehensive Cleanup in Version 1.2.3:
The 1.2.3 section documents the removal of beta prerelease tags and includes multiple updates such as adding a t3w1 internal_model, new messaging for LoadDevice, and changes to enum naming conventions. These detailed entries enhance understanding of internal adjustments. A thorough regression test is recommended to ensure that the removal of the “MessageType_” prefix and other renames do not break dependent systems.🧰 Tools
🪛 LanguageTool
[grammar] ~44-~44: The modal verb ‘will’ requires the verb’s base form.
Context: ...a2d) - chore: add no-empty as it will became part of recommanded (ef2dd42) - fe...(MD_BASEFORM)
packages/connect/CHANGELOG.md (7)
1-11: Updated Package and Deployment Versions:
The version table now reflects stable releases for @trezor/connect, @trezor/connect-web, and @trezor/connect-webextension updated to 9.5.2, while the deployment link for connect.trezor.io/ also shows 9.5.2. This aligns well with the stable release rollout, with the mobile package remaining in beta as expected.
14-17: Dependency Replacement for Solana:
The update in the “9.5.2-beta.2” section replacing @solana/web3.js with @solana/kit is clearly documented. Please ensure that this new dependency has been tested for full compatibility across environments.
18-25: Enhancements in 9.5.2-beta.1:
New features—such as forwarding device events in popup mode and automatically enabling coreMode—are introduced here. Alongside these, several chore items (e.g. updating device authenticity config and adding firmware binary support) are noted. It is important that these enhancements are verified across different integration scenarios to prevent any regressions.🧰 Tools
🪛 LanguageTool
[typographical] ~22-~22: Consider adding a comma after this introductory phrase.
Context: ... device events in popup mode (8589d27). From now on you may listen for device events even i...(FROM_NOW_ON_COMMA)
[grammar] ~23-~23: The word “fallback” is a noun. The verb is spelled with a space.
Context: ...init, TrezorConnect would automatically fallback to loading connect-core into popup.html...(NOUN_VERB_CONFUSION)
38-51: Version 9.5.1 Feature and Fix Updates:
The 9.5.1 block documents the addition of extra backends for EVM (with four endpoints per EVM) and includes adjustments for rent fee calculation alongside fixes such as improving device detection and handling timeouts. Ensure that these feature updates and corrections are consistent with the expectations established in the beta versions.
53-68: Major Update in 9.5.0 – ES2022 Target:
The changelog entry for 9.5.0 highlights the move to ES2022 for all @trezor packages. This is a significant change, and users on older environments or TS configurations will need to adjust their settings accordingly. Clear communication of this requirement is critical.🧰 Tools
🪛 LanguageTool
[uncategorized] ~54-~54: Possible missing comma found.
Context: ... (522880d) # 9.5.0 Starting with this release we changed de target in all@trezorp...(AI_HYDRA_LEO_MISSING_COMMA)
[misspelling] ~54-~54: Did you mean the article “the”?
Context: ... Starting with this release we changed de target in all@trezorpackages to ES2...(DE_THE)
[style] ~54-~54: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...ES2022. It might be problematic in some very old environment or if you use Typescript wi...(EN_WEAK_ADJECTIVE)
[grammar] ~54-~54: Consider using either the past participle “included” or the present participle “including” here.
Context: ...S2022 lib to your tsconfig. We are also include esm builds in our npm packages. For now...(BEEN_PART_AGREEMENT)
69-88: Fixes and Feature Enhancements in 9.5.0:
Multiple fixes such as addressing firmware update detection issues, employing serializeError during FW checks, and improving transaction decoding are documented here. These improvements should help enhance stability and usability, but it is recommended to perform thorough regression tests to verify that these changes resolve the intended bugs without side effects.
90-114: Chore and Maintenance Updates in 9.5.0:
The list of chores includes updates to build targets (root tsconfig.lib ES2022), dependency adjustments, warnings regarding deprecated configurations, and other internal cleanups. These maintenance tasks are crucial for long-term code health; however, please verify that none of these changes unintentionally affect the public API or user experience.packages/protocol/CHANGELOG.md (14)
1-6: Version 1.2.4 Update for Protocol Package:
This section removes the beta prerelease (1.2.4-beta.2) and the beta entry for @trezor/connect while adding the new feature “protocol‑v2.” These changes signal a move toward the stable integration of protocol version 2. Confirm that all external references and documentation have been updated accordingly.
7-11: Version 1.2.3 Cleanup:
The beta prerelease tag for version 1.2.3 (1.2.3-beta.1) is removed here, along with a fix for the package generation script. This cleanup helps maintain consistency.
12-16: Version 1.2.2 Adjustments:
By removing the beta label for version 1.2.2 and cleaning up global NX/workspace link scripts (and resolving ignore issues for devDependencies), this update simplifies the internal build process.
17-21: Version 1.2.1 Enhancements:
The changelog for version 1.2.1 now omits the beta tag and introduces a new feature that adds a “name” field to the TransportProtocol. This update is clear and should improve protocol clarity.
22-27: Version 1.2.0 Update:
Entries for version 1.2.0 show the removal of the label for1.1.1-beta.1, an update in transaction version numbers (txs updated from 4.7.0 to 4.16.2), and an enhancement to allow Buffer inputs in the decode function. Please verify that these dependency changes are backward compatible.
28-31: Beta Entry for Version 1.0.10-beta.2:
A chore has been added to enable depcheck. This is primarily a development-focused update and appears acceptable in its context.
32-35: Version 1.0.10-beta.1 Update:
The addition of a logging message when encountering an empty buffer in the protocol is a helpful debugging aid. Just ensure that the log does not leak sensitive information.
36-41: Version 1.0.8 Enhancements:
This update separates the chunking logic from encoding and standardizes the encoding/decoding of the message type as a string. Renaming the decode response fields further improves clarity and consistency in the protocol handling.
42-46: Version 1.0.7 Update:
The removal of TypeScript project references for build:libs and the transition toward a buildless monorepo are recorded here. This indicates an internal restructuring that should reduce build complexity.
47-59: Version 1.0.6 Updates:
A series of fixes and improvements—including switching from global to local tsx usage, removal of build:lib for simple packages, and updates to TypeScript/Jest configurations—should help streamline the development and build process. Ensure these changes harmonize well with the overall monorepo build system.
60-68: Version 1.0.4 Improvements:
This section documents the removal of thebytebufferdependency and the adoption oftslibin all public libraries, as well as protocol transport enhancements and the addition of unit tests. It is recommended to review that these dependency removals do not inadvertently break any legacy behavior.
69-75: Version 1.0.3 Maintenance:
Updates here include TypeScript version upgrades, dependency adjustments, and desktop package improvements. It would be beneficial to cross-check these changes against the related package updates to maintain consistency.🧰 Tools
76-79: Version 1.0.1 Minor Update:
A cleanup addressing missing fields in package.json is noted. Such improvements in metadata help ensure proper package configuration.
80-84: Initial Stable Release Entry (Version 1.0.0):
The final entry establishes the introduction of the protobuf and protocol packages and notes the reorganized protocol-related logic. This foundational entry is critical; please confirm that all key initial build steps and dependency configurations are fully captured.packages/transport/CHANGELOG.md (1)
1-8: New Version Entry for 1.4.2 Added SuccessfullyThe new changelog entry for version 1.4.2 correctly documents the following changes:
- A npm prerelease for
@trezor/transportversion 1.4.2-beta.2.- A fix for the UDP functionality to correctly read from a buffer or promise.
- A npm-release entry for
@trezor/connectas 9.5.2-beta.1 (referencing PR npm-release: @trezor/connect 9.5.2-beta.1 #17529).- A new feature to load protobuf definitions.
- A chore updating the
buildMessageparameter fromencodetoprotocol.Please verify that the beta designation for the
@trezor/connectrelease is intentional if a final stable release was expected.packages/blockchain-link/CHANGELOG.md (1)
1-7: New Version Entry for 2.4.2 DocumentedThe changelog entry for version 2.4.2 clearly captures:
- A npm prerelease for
@trezor/blockchain-linkversion 2.4.2-beta.2.- A chore updating all
@solana-program/*dependencies to versions that rely on@solana/kit.- A chore replacing
@solana/web3.jswith@solana/kit.- A npm-release entry for
@trezor/connectas 9.5.2-beta.1.Everything appears consistent with the coordinated release strategy.
packages/connect-common/CHANGELOG.md (1)
1-7: New Version Entry for 0.3.2 UpdatedThe changelog entry for version 0.3.2 includes:
- A npm prerelease for
@trezor/connect-commonversion 0.3.2-beta.2.- A npm-release for
@trezor/connectas 9.5.2-beta.1 (PR npm-release: @trezor/connect 9.5.2-beta.1 #17529).- A fix that reverts the previous bump of the
min_bootloader_versionfor t3b1.- A chore adding firmware binaries for version 2.8.9.
These updates align well with the intended release changes.
packages/device-utils/CHANGELOG.md (1)
1-44: Comprehensive Changelog for Device-Utils 1.0.1The changelog for version 1.0.1 thoroughly documents numerous updates, including:
- Adding tsx as a dev dependency and preparing the package for an npm release.
- Refactoring efforts to remove the dependency on
connectfrom components and movingDeviceModelInternalinto the package.- The introduction of the
FirmwareVersionStringtype.- Updating the function signatures—such as having
pickByDeviceModelacceptnullvalues and enforcing a stricter return type forgetFirmwareVersion.- Adding unit tests for the
pickByDeviceModelutility.- Various dependency cleanups and configuration improvements.
Overall, this update is well-documented and aligns with the npm release objectives.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/connect/CHANGELOG.md (1)
19-19: Refine CoreMode Feature DescriptionThe feature description for enabling the auto
coreModeis now updated. It specifies that if you don't passcoreModeinTrezorConnect.init, the function will automatically fall back to loadingconnect-coreintopopup.htmlrather than injecting the iframe. For clarity, consider adjusting the phrase from"instead loading it into the injected iframe"
to
"instead of loading it into the injected iframe."
This minor wording revision will improve readability without affecting functionality.
🧰 Tools
🪛 LanguageTool
[grammar] ~19-~19: The word “fallback” is a noun. The verb is spelled with a space.
Context: ...init, TrezorConnect would automatically fallback to loading connect-core into popup.html...(NOUN_VERB_CONFUSION)
[uncategorized] ~19-~19: Possible missing preposition found.
Context: ...ng connect-core into popup.html instead loading it into the injected iframe. This fallb...(AI_EN_LECTOR_MISSING_PREPOSITION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/connect/CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
packages/connect/CHANGELOG.md
[typographical] ~18-~18: Consider adding a comma after this introductory phrase.
Context: ... device events in popup mode (8589d27). From now on you may listen for device events even i...
(FROM_NOW_ON_COMMA)
[grammar] ~19-~19: The word “fallback” is a noun. The verb is spelled with a space.
Context: ...init, TrezorConnect would automatically fallback to loading connect-core into popup.html...
(NOUN_VERB_CONFUSION)
[uncategorized] ~19-~19: Possible missing preposition found.
Context: ...ng connect-core into popup.html instead loading it into the injected iframe. This fallb...
(AI_EN_LECTOR_MISSING_PREPOSITION)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: PR-check / node-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
- GitHub Check: PR-check / node-override init-api-flaky
- GitHub Check: PR-check / web-override init-api-flaky
- GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
- GitHub Check: build-deploy
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: build-deploy
- GitHub Check: prepare_android_test_app
- GitHub Check: EAS Update
- GitHub Check: transport-e2e-test
- GitHub Check: build-web
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: test
🔇 Additional comments (4)
packages/connect/CHANGELOG.md (4)
3-5: Update Package Versions in Changelog TableThe stable versions for
@trezor/connect,@trezor/connect-web, and@trezor/connect-webextensionhave been updated to 9.5.2 with the canary column now removed. This change clearly reflects the transition to a stable release per the PR objectives.
8-10: Update Deployment Version EntryThe deployment table now shows the stable version 9.5.2 for
connect.trezor.io/with the canary entry removed. This update is consistent with the overall release versioning strategy.
14-14: Release Header Version UpdateThe changelog header now correctly displays the version 9.5.2. This update aligns with the release bump and ensures that users can clearly identify the stable release.
23-27: Chore Updates and Consistency CheckThe chore section now includes several updates such as:
- Replacing
@solana/web3.jswith@solana/kit- Updating the device authenticity config
- Adding firmware binaries for version 2.8.9
- Stopping the export of the
DeviceModelInternalenum- Bumping the deprecation warning in
connect-popupto 9.4.0These changes are in line with the overall dependency and version updates outlined in the PR objectives. Please verify that all references to removed exports (e.g.,
DeviceModelInternal) have been updated elsewhere in the codebase.
| @@ -11980,6 +11980,8 @@ __metadata: | |||
| "@trezor/device-utils@workspace:*, @trezor/device-utils@workspace:packages/device-utils": | |||
| version: 0.0.0-use.local | |||
| resolution: "@trezor/device-utils@workspace:packages/device-utils" | |||
| dependencies: | |||
| tsx: "npm:^4.19.3" | |||
There was a problem hiding this comment.
This is because we added tsx as cherry-pick, that was a requirement for releasing device-utils package.
| @@ -1,3 +1,7 @@ | |||
| # 1.3.2 | |||
|
|
|||
| - npm-prerelease: @trezor/analytics 1.3.2-beta.1 (da51b9cf12) | |||
There was a problem hiding this comment.
I would say this type of commit shouldn't be here, but let's deal with this later sometime
There was a problem hiding this comment.
Yes, I know this type of changelog does not add much value. I am in for improving it but this is actually the only commit that was generated to this package. And the package requires to be updated becuase it's dependency @trezor/utils was updated and therefore this package has to be released as well.
This kind of conclusions are very difficult to create in an automate way. And since our focus is to create a good changelog for @trezor/connect so we decided to leave this kind of changelogs like that.
But I am happy to listen other ideas.
There was a problem hiding this comment.
Maybe one easy and straight forward idea could be to not include the commits starting with npm-prerelease But then it would be nice to add something not only the version number.
Maybe we can assume that it was updated because a dependency was updated if there are no commits and add a message saying something like: Releasing due to dependencies update.
WDYT? ❓
karliatto
added
the
no-project
|
|
||
| - fix(device-utils): add tsx as dev dependency (75e2cf82af) | ||
| - npm-prerelease: @trezor/device-utils 1.0.1-beta.1 (65fb5950b5) | ||
| - chore(device-utils): prepare setup for npm release (e4c32edb37) | ||
| - chore: more refactorign to remove connect from components (3736dec0a5) | ||
| - chore: move DeviceModelInternal to device-utils (0bcf666672) | ||
| - chore(monorepo): remove dependency on connect in components and device-utils (465f40a072) |
There was a problem hiding this comment.
these records make no sense. it probably takes some default max number of records because it wasn't able to find previsou changelog commit..
@trezor/connect bump version
This is an automatically created PR.
yarn workspace @trezor/connect version:<beta|patch|minor|major>yarn tsx check-npm-dependencies.ts <package_name> <semver>. Please note that this script will report unreleased dependencies even for changes that do not affect runtime (READMEs etc.)