Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(demo-standard): add Standard Integration to demo #32

Merged
merged 22 commits into from
Oct 20, 2018
Merged

feat(demo-standard): add Standard Integration to demo #32

merged 22 commits into from
Oct 20, 2018

Conversation

RobertGardner
Copy link
Collaborator

PR Checklist

Modifies the demo app to match the demo-angular app, with support for the Standard Integration and a "Create Token" button in the Custom Integration.

Closes #25 .
Closes #19 . This is the final PR for the Standard Integration implementation.

Robert Gardner and others added 22 commits September 21, 2018 06:27
Add support for Stripe Standard Integration.
ee5ff39
Add bug ID to CHANGELOG entry.
3771325
Add tns-core-modules path to demo tsconfig.
92870af 
This is now the recommended setting.
Merge branch 'master' into standard-integration
bc6595a
Add Angular demo that illustrates Standard Integration. (#23)
b871c9d
Update .travis.yml to match current plugin-seed.
2be5db5
Update devDependencies to match latest plugin-seed.
0a8e520
Add pod update to travis build script.
62e7d59
Oops, last updates to .travis.yml were wrong.
75e4998 
Revert then add demo-angular support.
Now update to work correctly with the new package.json scripts.
012ddf4
Another place in .travis.yml that needs an 'npm i'.
9c13da3
Get bundling working for 'standard' package.
f16bb9e
Add Custom Integration to the angular demo.
80114db 
Required changing the Angular implementation to follow the current recommendations.

Required minor changes to the Custom Integration API to make  it
consistent across platforms.
Fix demo app to use new API.
ba3eccf
Fix Webpack problerm.
3f2399d
Better error handling in CCView Demo.
8cd42fb
Create main page and implement the CCView demo.
d1d5064
Add support for Standard Demo.
1f551c0
@RobertGardner
Merge with Master.
637a2ab
@RobertGardner
Merge branch 'master' into demo-standard
0032972
@RobertGardner
Manage page data using standard Model/Observable technique.
2e4720b
@RobertGardner
Update version no., changelog, and readme.
ad2c997
@RobertGardner
Copy link
Collaborator Author

I updated the demo app to match the demo-angular app, which has a main screen with buttons for the Standard and Custom Integration demos, adds a "Create Token" button to the Custom Demo, and uses the same implementation of the Standard Integration as is found in demo-angular.

Since this modifies demo and changes its behavior, I'd like to get your approval before submitting it.

There are no changes to the plugin code, just to the demo app.

triniwiz
triniwiz approved these changes Oct 20, 2018
View reviewed changes
Copy link
Owner

@triniwiz triniwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertGardner RobertGardner merged commit 908425c into master Oct 20, 2018
@RobertGardner RobertGardner deleted the demo-standard branch October 20, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triniwiz triniwiz triniwiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGardner @triniwiz