This repository was archived by the owner on Jun 22, 2023. It is now read-only.
feat(schema): Use custom trompa type for additionalProperty field #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the additionalProperty field is only valid on a few schema.org types, not all types as we implemented here. Because the field is useful for us in a few ways, define our own custom type for this field so that we don't break schema.org rules.
ChristiaanScheermeijer
approved these changes
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the additionalProperty field is only valid on a few schema.org types,
not all types as we implemented here. Because the field is useful for us
in a few ways, define our own custom type for this field so that we
don't break schema.org rules.