Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI doesn't check logs #114

Closed
sosthene-nitrokey opened this issue Apr 4, 2023 · 0 comments · Fixed by #206
Closed

CI doesn't check logs #114

sosthene-nitrokey opened this issue Apr 4, 2023 · 0 comments · Fixed by #206

Comments

@sosthene-nitrokey
Copy link
Contributor

The CI runs checks only with either all features enabled or none. As a consequence it never checks that trussed compiles with logs enabled (they are either not enabled or disabled with log-none).

Ideally delog would still type-check everything even when disabled like log and debug_assert! do. See trussed-dev/delog#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Check logging code trussed-dev/trussed
1 participant
@sosthene-nitrokey