Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Running mypy with reviewdog 🐶 ..." does not comment and shows no error, despite errors. #115

Closed
bernhardkaindl opened this issue Jan 28, 2024 · 4 comments
Assignees

Comments

@bernhardkaindl
Copy link
Contributor

bernhardkaindl commented Jan 28, 2024

I run into the same issue as the 2nd issue reported in #111:

Second, the step "Running mypy with reviewdog 🐶 ..." shows no output and passes without errors, even when there are typing errors in the project:

I enabled mypy --verbose and see that mypy is issuing two warnings for a file (it mentions two times that it has a warning about a place in the file), in the step "Running mypy with reviewdog 🐶 ...", but the action hides the actual errors and does not add a comment to the PR.

@bernhardkaindl
Copy link
Contributor Author

bernhardkaindl commented Jan 28, 2024

Example PR: #xenserver-next/xen-api#6

In this PR, there are some comments but they are incomplete:

🚫 [mypy] reported by reviewdog 🐶
Function is

Also, the file from which I get errors has more errors that are not added as comments.

Workflow output: https://github.com/xenserver-next/xen-api/actions/runs/7688914348/job/20950684779?pr=6

I am still trying to diagnose it.

I also have scripts that parse the output of pytype, pylint and pyre and output GitHub annotation messages. Maybe one can be updated for mypy. It could help with converting the output into a format that reviewdog can digest better (also with respect to multiple line errors).

@tsuyoshicho
Copy link
Owner

Hi @bernhardkaindl

Thank you

Wait a little longer

@tsuyoshicho tsuyoshicho self-assigned this Jan 29, 2024
@tsuyoshicho
Copy link
Owner

Hi @bernhardkaindl

https://github.com/xenserver-next/xen-api/actions/runs/7688914348/job/20950684779?pr=6
#38
mypy may return multi-line results.
Cannot be improved until a solution is created, such as being able to get results in JSON!

This can be mitigated somewhat with ignore_note.

Your PR is helpful, I will examine it and merge it.

@tsuyoshicho
Copy link
Owner

Hi @bernhardkaindl

I have released v4.0.1.
Please try to understand and use the above support.

https://github.com/tsuyoshicho/action-mypy/releases/tag/v4.0.1

This issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants