-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Running mypy with reviewdog 🐶 ..." does not comment and shows no error, despite errors. #115
Comments
Example PR: #xenserver-next/xen-api#6 In this PR, there are some comments but they are incomplete:
Also, the file from which I get errors has more errors that are not added as comments. Workflow output: https://github.com/xenserver-next/xen-api/actions/runs/7688914348/job/20950684779?pr=6 I am still trying to diagnose it. I also have scripts that parse the output of pytype, pylint and pyre and output GitHub annotation messages. Maybe one can be updated for mypy. It could help with converting the output into a format that reviewdog can digest better (also with respect to multiple line errors). |
Thank you Wait a little longer |
https://github.com/xenserver-next/xen-api/actions/runs/7688914348/job/20950684779?pr=6 This can be mitigated somewhat with Your PR is helpful, I will examine it and merge it. |
I have released v4.0.1. https://github.com/tsuyoshicho/action-mypy/releases/tag/v4.0.1 This issue is closed. |
I run into the same issue as the 2nd issue reported in #111:
I enabled mypy --verbose and see that mypy is issuing two warnings for a file (it mentions two times that it has a warning about a place in the file), in the step "Running mypy with reviewdog 🐶 ...", but the action hides the actual errors and does not add a comment to the PR.
The text was updated successfully, but these errors were encountered: