Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script.sh: Add set -euxv #116

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Update script.sh: Add set -euxv #116

merged 1 commit into from
Jan 29, 2024

Conversation

bernhardkaindl
Copy link
Contributor

closes #114

@bernhardkaindl
Copy link
Contributor Author

I haven't tested it yet, and it might abort early, but I wanted to submit this standard solution.

The set -euxv is the standard that I put in every script:

  • As the -u causes an error (and with -e an exit) on any unset variable, you may either omit the --u flag, or instead set empty default values for variables which might not be set (which would be better). The benefit of -u is in the latte way is that whenever there is a variable name issue (usually a typo or somehow a missing input) the script aborts at the location of the unset variable access.

@tsuyoshicho tsuyoshicho self-requested a review January 29, 2024 12:27
@tsuyoshicho
Copy link
Owner

Close #115

Additional corrections will be made in the next PR.

@tsuyoshicho tsuyoshicho merged commit 80ece7c into tsuyoshicho:master Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: something fails during setup, no error occurs.
2 participants