Switch the examples to use action v4 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
|
Hi @bernhardkaindl |
tsuyoshicho
approved these changes
Feb 3, 2024
|
This is not a problem and will be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated: Converted to draft because v4 is not ready yet, I started testing and it fails.
Do not merge!
After
action-mypyv4is tested and an improvement overv3, and you want new users to usev4instead ofv3you may update the examples inREADME.mdto usetsuyoshicho/action-mypy@v4.Of course, this is for just after you are confident in v4 to be ready.
PS, and off-topic: This PR includes that change too: While at it, you may also want to update actions/checkout from v2 to v4 because, as far as I am aware, there should be no reason for new users to copy the use of the use of older v2 of actions/checkout