-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display error overlay #607
Conversation
ef36f03
to
1c0c740
Compare
d7c4569
to
927cb43
Compare
ced09cc
to
c18590a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks pretty good. I don't understand the removal of the class fields on the ts side. Would you be able to tell me more about that?
@marcalexiei @jacobhq Updated! Let me know if I can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from me. Nice work!
Checklist
Related issue
Fixes #592
Overview
Implementation detail
The dialog is a vite internal web component that gets automatically triggered by its WebSocket connection.
In order to make this feature working I had to "hack" a little bit the current implementation
fallback_html
file that gets injected in.tuono/index.html
that simply renders the project client side and open the connection to the vite server.Implementation split
index.html
fromtuono
CLIerror-overlay.ts
component in the vite buildScreenshot
For this iteration the overlay is just a clone of the vite one. In the future we might need to refactor the UI in order to make it more
tuono
style like. No changes to the current PR should be required