feat(examples/tuono-tutorial): improve styles of PokemonView component
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasgasco
changed the title
marcalexiei
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
Hi @nicolasgasco,
Could you please check your code locally before opening a PR?
The CI was failing, but I’ve fixed it to avoid another round of review.
You can find the instructions here: https://tuono.dev/documentation/contributing/local-development#validate-your-changes.
Similar commands are also available for documentation.
marcalexiei
changed the title
marcalexiei
changed the title
PokemonView component
marcalexiei
changed the title
PokemonView component PokemonView component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related issue
Not an issue, but it's related to tuono-labs/tuono-documentation#55
Overview
The aim of this PR is improving the styles of the
PokemonViewcomponent in the Dynamic routes tutorial page.It is not a vital change, but, since we're asking the user to copy-paste styles, we might as well give it a more polished look.