feat: add __layout wrapper to default 404 page #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valerioageno
force-pushed
the
add-layout-to-404-page
branch
from
cc6fa5c to
ce918a3
Compare
marcalexiei
reviewed
Mar 9, 2025
There was a problem hiding this comment.
might also fix #617
Tested on examples/tuono-tutorial using local tuono build and the issue seems no longer present
|
All fair points. Applied! |
marcalexiei
approved these changes
Mar 9, 2025
This was referenced Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related issue
Fixes #622, might also fix #617
Overview
This PR adds the user defined
__layoutto the default 404 page