Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72 wrong calculations #73

Merged
merged 2 commits into from
Feb 24, 2021
Merged

72 wrong calculations #73

merged 2 commits into from
Feb 24, 2021

Conversation

Fubinator
Copy link
Member

Description

This fixes #72. The Impact Sub Score calculation differs in version 3.1 when calculating base and environmental score.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Fubinator Fubinator merged commit b2b580a into main Feb 24, 2021
@Fubinator Fubinator deleted the 72-wrong-calculations branch February 24, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid CVSS3.1 scores in some cases
1 participant