Added json parsing and something else #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when chaining getElement(), the library will no longer parse the HTML multiple times, causing unnecessary slowdown.
As per PR.
As per PR.
Other things done too, can't recall all now since i've done these changes several months ago, but code comparison should show what is new.
|
Upon further verification, it seems like i've actually done good commenting on the changes i've made. First, added the Also added the secondary function Hope this makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, i've done this change several months ago and never made a pull request, but this is supposed to parse JSON responses and do something else too. I think you can select direct URLs to load without giving a base URL first?
Sorry for throwing you under the bus and make you review a code change with so little information. This is super helpful for my application and hopefully it will be for others too, so please look at it with care.
Also i did something wrong that it didn't let me properly compare my old file with the new one. If you want to, feel free to make another pull request based of this one so it's easier/better for other people to understand the changes made.