Add detailed explanation of the JS components configuration merging process #37303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
gs/popover-fix-doc
branch
from
cfde8ec to
0c1af65
Compare
GeoSot
force-pushed
the
gs/popover-fix-doc
branch
from
0c1af65 to
ecd1968
Compare
mdo
reviewed
Oct 30, 2022
There was a problem hiding this comment.
Took a quick pass at editing the copy here. No need for the <small>. I'm not 100% on what we're saying here though, so wouldn't mind eyes from @XhmikosR or @julien-deramond.
GeoSot
force-pushed
the
gs/popover-fix-doc
branch
from
8168c4c to
e9d1e38
Compare
GeoSot
force-pushed
the
gs/popover-fix-doc
branch
from
175acb3 to
4cea03f
Compare
mdo
reviewed
Mar 25, 2023
mdo
approved these changes
Mar 25, 2023
XhmikosR
force-pushed
the
gs/popover-fix-doc
branch
from
7e7bae1 to
3a5e438
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some detailed explanation about the confg merging process of our JS components, and fix misleading popover & tooltip options description
Checklist
npm run lint)Live previews
https://deploy-preview-37303--twbs-bootstrap.netlify.app/docs/5.2/components/popovers/#options
https://deploy-preview-37303--twbs-bootstrap.netlify.app/docs/5.2/components/tooltips/#options
Related issues
closes #37298