Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: include index.{esm,umd}.js files too #37565

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

XhmikosR
Copy link
Member

This should allow people to easily import and build everything themselves.

@XhmikosR XhmikosR marked this pull request as ready for review December 1, 2022 18:14
@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 1, 2022

Not sure how many people will use it, but personally, I've hit a case where I wanted to build Bootstrap myself and I had to import each component separately.

@julien-deramond
Copy link
Member

julien-deramond commented Dec 1, 2022

On my side I don't mind adding these files if they can help some users :)

@GeoSot OK for you as well?

@GeoSot
Copy link
Member

GeoSot commented Dec 1, 2022

On my side I don't mind adding these files if they can help some users :)

@GeoSot OK for you as well?

TBH I am already using dynamic import import('bootstrap') and partial imports, but if it gives some more help to anyone, of course, I am on the same page here 😉

@XhmikosR XhmikosR merged commit af34b2b into main Dec 16, 2022
@XhmikosR XhmikosR deleted the xmr/pkg-index branch December 16, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants