Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard more in color-modes.js #38235

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Guard more in color-modes.js #38235

merged 2 commits into from
Mar 14, 2023

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 14, 2023 •
edited
Loading

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR marked this pull request as ready for review March 14, 2023 14:18
@XhmikosR XhmikosR requested a review from a team as a code owner March 14, 2023 14:18
@XhmikosR XhmikosR merged commit 474bf2a into main Mar 14, 2023
@XhmikosR XhmikosR deleted the XhmikosR-patch-2 branch March 14, 2023 18:30
@mdo
Copy link
Member

mdo commented Mar 20, 2023

This needs to be reverted, it breaks the color mode toggle.

mdo added a commit that referenced this pull request Mar 20, 2023
@mdo
Revert "Guard more in color-modes.js (#38235)"
a9a5b4e 
This reverts commit 474bf2a.
@mdo mdo mentioned this pull request Mar 20, 2023
Merged
mdo added a commit that referenced this pull request Mar 20, 2023
@mdo
Revert "Guard more in color-modes.js (#38235)" (#38280)
6855ce9 
This reverts commit 474bf2a.
@XhmikosR XhmikosR added the skip-changelog So that the release drafter action doesn't include it label Mar 20, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs js skip-changelog So that the release drafter action doesn't include it v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @mdo