-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-sass workflow: improve error message when Sass vars are found #38448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
620dddd
to
6d80576
Compare
6d80576
to
13c031d
Compare
13c031d
to
8035fe2
Compare
ff6792a
to
8035fe2
Compare
XhmikosR
approved these changes
Apr 13, 2023
node-sass
error message when Sass vars are found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests improving the error message of the
node-sass
workflow when we find Sass variables indist-sass
.In the first commit, I voluntarily reverted some changes in our CSS files in https://github.com/twbs/bootstrap/pull/38448/files to show the new error message.
It can be found here: https://github.com/twbs/bootstrap/actions/runs/4679714004/jobs/8290111973?pr=38448.
Then, the second commit rollbacks the wrong changes so that the workflow is green again.
Extra information:
bash {0}
is used to avoid "Fail-fast behavior" (See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference)Motivation & Context
When it's not possible to run
npx
locally because of security rules in a company or because you don't remember the command line, it can be really handy to have the list of the errors directly in the logs of the failed workflow.Type of changes
Checklist
npm run lint
)