Remove useEffects

twentyhq · Dec 19, 2024 · 9870ea2 · 9870ea2
1 parent 355169a
commit 9870ea2
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 35 deletions.
diff --git a/...t/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormCreateRecord.tsx b/...t/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormCreateRecord.tsx
@@ -99,13 +99,6 @@ export const WorkflowEditActionFormCreateRecord = ({
     saveAction(newFormData);
   };
 
-  useEffect(() => {
-    setFormData({
-      objectName: action.settings.input.objectName,
-      ...action.settings.input.objectRecord,
-    });
-  }, [action.settings.input]);
-
   const saveAction = useDebouncedCallback(
     async (formData: CreateRecordFormData) => {
       if (actionOptions.readonly === true) {

diff --git a/...t/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormDeleteRecord.tsx b/...t/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormDeleteRecord.tsx
@@ -1,7 +1,7 @@
 import { useFilteredObjectMetadataItems } from '@/object-metadata/hooks/useFilteredObjectMetadataItems';
 import { Select, SelectOption } from '@/ui/input/components/Select';
-import { WorkflowStepHeader } from '@/workflow/components/WorkflowStepHeader';
 import { WorkflowSingleRecordPicker } from '@/workflow/components/WorkflowSingleRecordPicker';
+import { WorkflowStepHeader } from '@/workflow/components/WorkflowStepHeader';
 import { WorkflowDeleteRecordAction } from '@/workflow/types/Workflow';
 import { useTheme } from '@emotion/react';
 import { useEffect, useState } from 'react';
@@ -12,9 +12,9 @@ import {
   useIcons,
 } from 'twenty-ui';
 
+import { WorkflowStepBody } from '@/workflow/components/WorkflowStepBody';
 import { JsonValue } from 'type-fest';
 import { useDebouncedCallback } from 'use-debounce';
-import { WorkflowStepBody } from '@/workflow/components/WorkflowStepBody';
 
 type WorkflowEditActionFormDeleteRecordProps = {
   action: WorkflowDeleteRecordAction;
@@ -69,13 +69,6 @@ export const WorkflowEditActionFormDeleteRecord = ({
     saveAction(newFormData);
   };
 
-  useEffect(() => {
-    setFormData({
-      objectName: action.settings.input.objectName,
-      objectRecordId: action.settings.input.objectRecordId,
-    });
-  }, [action.settings.input]);
-
   const selectedObjectMetadataItemNameSingular = formData.objectName;
 
   const selectedObjectMetadataItem = activeObjectMetadataItems.find(

diff --git a/...ront/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormSendEmail.tsx b/...ront/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormSendEmail.tsx
@@ -75,15 +75,6 @@ export const WorkflowEditActionFormSendEmail = ({
     }
   };
 
-  useEffect(() => {
-    setFormData({
-      connectedAccountId: action.settings.input.connectedAccountId,
-      email: action.settings.input.email,
-      subject: action.settings.input.subject ?? '',
-      body: action.settings.input.body ?? '',
-    });
-  }, [action.settings.input]);
-
   const saveAction = useDebouncedCallback(
     async (formData: SendEmailFormData, checkScopes = false) => {
       if (actionOptions.readonly === true) {

diff --git a/...t/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormUpdateRecord.tsx b/...t/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormUpdateRecord.tsx
@@ -91,15 +91,6 @@ export const WorkflowEditActionFormUpdateRecord = ({
     saveAction(newFormData);
   };
 
-  useEffect(() => {
-    setFormData({
-      objectName: action.settings.input.objectName,
-      objectRecordId: action.settings.input.objectRecordId,
-      fieldsToUpdate: action.settings.input.fieldsToUpdate ?? [],
-      ...action.settings.input.objectRecord,
-    });
-  }, [action.settings.input]);
-
   const selectedObjectMetadataItemNameSingular = formData.objectName;
 
   const selectedObjectMetadataItem = activeObjectMetadataItems.find(
@@ -149,7 +140,7 @@ export const WorkflowEditActionFormUpdateRecord = ({
           ...action.settings,
           input: {
             objectName: updatedObjectName,
-            objectRecordId: updatedObjectRecordId ?? '',
+            objectRecordId: updatedObjectRecordId,
             objectRecord: updatedOtherFields,
             fieldsToUpdate: updatedFieldsToUpdate ?? [],
           },