Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invite by email table overflows in mobile viewport #7253

Closed
harshit078 opened this issue Sep 25, 2024 · 6 comments
Closed

Invite by email table overflows in mobile viewport #7253

harshit078 opened this issue Sep 25, 2024 · 6 comments
Assignees
@harshit078
Labels
prio: med scope: front Issues that are affecting the frontend side only type: design improvement

Comments

@harshit078
Copy link
Contributor

Bug Description

  • Go to workspace/Members
  • Add emails to be invited
  • when email input is long then the table overflows.

Current behaviour

Screenshot 2024-09-25 at 6 36 15 PM

Expected behavior

Screenshot 2024-09-25 at 6 48 13 PM
@Bonapara
Copy link
Member

🙏🙏

@Bonapara Bonapara added scope: front Issues that are affecting the frontend side only type: design improvement prio: low prio: med and removed prio: low labels Sep 25, 2024
@dilshad-knk
Copy link
Contributor

hey can i work on this

@ehconitin
Copy link
Contributor

@harshit078 are you working on it yourself? or should I assign @dilshad-knk ? ;)

@harshit078
Copy link
Contributor Author

@ehconitin I'm working on this :)

@ehconitin
Copy link
Contributor

@dilshad-knk Thankyou for contributing, please pick another good first issue from here :)

@harshit078 harshit078 mentioned this issue Sep 26, 2024
Merged
martmull pushed a commit that referenced this issue Oct 8, 2024
@harshit078 @ehconitin
fix: Invite by email table overflows in mobile viewport (#7273)
098551b 
##Description

- This PR solves the issue #7253
- Made the invite table mobile friendly for all media width

## Before


https://github.com/user-attachments/assets/458bd47d-38fb-4ddc-a996-c1bb3908d014

<img width="439" alt="Screenshot 2024-09-27 at 1 30 52 AM"
src="https://github.com/user-attachments/assets/2a0ba6a2-c0f6-42bb-b74d-3a3147f2e7e7">

## After

<img width="440" alt="Screenshot 2024-09-27 at 1 34 11 AM"
src="https://github.com/user-attachments/assets/d31fdeba-574a-4cd0-a61a-bb5fba656109">


https://github.com/user-attachments/assets/7a4f6f9a-7fef-42f1-a226-59a1d73767f4


> [!Note]
> I've added 2 implementations and if either doesn't follow design rules
then it can be changed-
> - Made the trash icon `accent danger`
> - When emails are long, given scroll for ease of convience.

---------

Co-authored-by: Nitin Koche <nitinkoche03@gmail.com>
@ehconitin
Copy link
Contributor

closed in #7273

harshit078 added a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@harshit078 @ehconitin
fix: Invite by email table overflows in mobile viewport (twentyhq#7273)
10372bd 
##Description

- This PR solves the issue twentyhq#7253
- Made the invite table mobile friendly for all media width

## Before


https://github.com/user-attachments/assets/458bd47d-38fb-4ddc-a996-c1bb3908d014

<img width="439" alt="Screenshot 2024-09-27 at 1 30 52 AM"
src="https://github.com/user-attachments/assets/2a0ba6a2-c0f6-42bb-b74d-3a3147f2e7e7">

## After

<img width="440" alt="Screenshot 2024-09-27 at 1 34 11 AM"
src="https://github.com/user-attachments/assets/d31fdeba-574a-4cd0-a61a-bb5fba656109">


https://github.com/user-attachments/assets/7a4f6f9a-7fef-42f1-a226-59a1d73767f4


> [!Note]
> I've added 2 implementations and if either doesn't follow design rules
then it can be changed-
> - Made the trash icon `accent danger`
> - When emails are long, given scroll for ease of convience.

---------

Co-authored-by: Nitin Koche <nitinkoche03@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshit078 harshit078

Labels
prio: med scope: front Issues that are affecting the frontend side only type: design improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Bonapara @harshit078 @dilshad-knk @ehconitin