I18n ci 5 #10247
Merged
I18n ci 5 #10247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the i18n translation workflow by adding a stash step before pulling translations from Crowdin, which could impact translation synchronization.
- Added
git stashstep in.github/workflows/i18n-pull.yamlthat may lead to lost changes since stashed content is never restored - Missing error handling for stash operation failures in
.github/workflows/i18n-pull.yaml - No conditional check before stashing to verify if there are actual changes to preserve
- Workflow lacks handling for potential merge conflicts during stash operation
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
.github/workflows/i18n-pull.yaml
Outdated
Comment on lines
67
to
68
| git add . | ||
| git stash |
There was a problem hiding this comment.
style: Consider checking if there are changes to stash before running git stash
Suggested change
| git add . | |
| git stash | |
| if ! git diff --quiet; then | |
| git stash | |
| fi |
eliezer-rodrigues037
pushed a commit
to mind-developer/kvoip-v2
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.