410 open in side panel

[bosiraphael]

Closes twentyhq/core-team-issues#410

• Added openRecordIn column in the view entity, which is set to SIDE_PANEL by default
• Created a new option inside the view option dropdown to be able to set openRecordIn
• Updated all record show page openings to reflect the setting behavior
• For workflow, workflowVersion and workflowRun (what I call workflow objects), we want the default view openRecordIn to be set to RECORD_PAGE. When seeding the views for the new workspaces, we set openRecordIn to RECORD_PAGE for workflow objects. Since the workflow objects views openRecordIn will be set to the default value SIDE_PANEL for the existing workspaces when the sync metadata runs, I created a script to run in the 0.43 update to update this value.
• Updated closeCommandMenu because of problems introduced by the animate presence wrapper around the command menu. We now reset the states at the end of the animation.

Note: We want to be able to open all workflow objects pages in the side panel, but this requires some refactoring of the workflow module. For now @Bonapara wanted to allow the possibility to change the openRecordIn setting to SIDE_PANEL even for the workflows even if it's buggy and not ready for the moment. Since this is an experimental feature, it shouldn't cause too many problems.

[greptile-apps]

PR Summary

This PR adds functionality to control how records are opened (in a side panel or record page) through a new openRecordIn column in the view entity, with workflow objects defaulting to record page view.

• Added ViewOpenRecordInType enum and openRecordIn field to view entity, defaulting to SIDE_PANEL for most objects
• Implemented view settings dropdown UI with "Open in" option to toggle between side panel and record page modes
• Added migration script UpdateDefaultViewRecordOpeningOnWorkflowObjectsCommand to set workflow objects to RECORD_PAGE by default
• Fixed command menu animation issues by splitting close functionality into two parts: initial close and post-animation cleanup
• Removed hardcoded workflow object show page redirection in favor of configurable view-level settings

_{38 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile}

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ Error: Should never occur, encountered unknown fields openRecordIn in objectMetadataItem view /welcome View Issue
• ‼️ TypeError: Cannot read properties of undefined (reading 'primaryEmail') /objects/workflows View Issue
• ‼️ TypeError: Cannot read properties of undefined (reading 'primaryEmail') /object/workflowRun/7d76e5d6-5d92-4b08-b53c-07e... View Issue

_{Did you find this useful? React with a 👍 or 👎}