[permissions] Move SettingsPermissions from twenty-shared to twenty-server #10430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR relocates the SettingsPermissions enum from twenty-shared to twenty-server package, improving architectural boundaries by keeping server-specific permissions within the server codebase.
- Moved
SettingsPermissionsenum to/packages/twenty-server/src/engine/metadata-modules/permissions/constants/settings-permissions.constants.ts - Updated import paths across 14 resolver and module files to use new local path
- Removed
SettingsPermissionsexport from/packages/twenty-shared/src/constants/index.ts - Maintains all existing permission values and functionality while consolidating server-side concerns
15 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -7,7 +7,7 @@ import { | |||
| } from '@nestjs/common'; | |||
| import { GqlExecutionContext } from '@nestjs/graphql'; | |||
|
|
|||
| import { SettingsPermissions } from 'twenty-shared'; | |||
| import { SettingsPermissions } from "src/engine/metadata-modules/permissions/constants/settings-permissions.constants"; | |||
There was a problem hiding this comment.
style: Double quotes used for import statement while single quotes are used elsewhere. Maintain consistent quote style.
ijreilly
force-pushed
the
perm--move-settings-permissions
branch
from
b13a561 to
c37792c
Compare
Weiko
approved these changes
Feb 24, 2025
| @@ -7,7 +7,7 @@ import { | |||
| } from '@nestjs/common'; | |||
| import { GqlExecutionContext } from '@nestjs/graphql'; | |||
|
|
|||
| import { SettingsPermissions } from 'twenty-shared'; | |||
| import { SettingsPermissions } from "src/engine/metadata-modules/permissions/constants/settings-permissions.constants"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.