Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command menu list item overflow #10544

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

bosiraphael
Copy link
Contributor

Before:
Capture d’écran 2025-02-27 à 12 10 52

After:
Capture d’écran 2025-02-27 à 12 10 40

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes text overflow in command menu list items by implementing proper text truncation with tooltips.

  • Added OverflowingTextWithTooltip component in packages/twenty-ui/src/navigation/menu-item/components/MenuItemCommand.tsx to handle text overflow with tooltip display on hover
  • Added overflow: hidden to StyledTextContainer to ensure text stays within its container boundaries
  • Replaced direct text rendering with OverflowingTextWithTooltip component to provide better UX for long menu item texts
  • Ensures consistent UI appearance by preventing text from breaking the menu item layout

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@bosiraphael bosiraphael enabled auto-merge (squash) February 27, 2025 11:31
@bosiraphael bosiraphael merged commit fb38828 into main Feb 27, 2025
47 checks passed
@bosiraphael bosiraphael deleted the r--fix-command-menu-list-item-overflow branch February 27, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants