Add search to cmd bar #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
front/src/AppNavbar.tsx
Outdated
| @@ -20,6 +22,8 @@ export function AppNavbar() { | |||
| const theme = useTheme(); | |||
| const currentPath = useLocation().pathname; | |||
|
|
|||
| const setCommandBarOpen = useSetRecoilState(isCommandMenuOpenedState); | |||
There was a problem hiding this comment.
Suggested change
| const setCommandBarOpen = useSetRecoilState(isCommandMenuOpenedState); | |
| const setIsCommandMenuOpened = useSetRecoilState(isCommandMenuOpenedState); |
front/src/AppNavbar.tsx
Outdated
| icon={<IconSearch size={theme.icon.size.md} />} | ||
| soon={true} | ||
| onClick={() => setCommandBarOpen(true)} |
There was a problem hiding this comment.
Suggested change
| onClick={() => setCommandBarOpen(true)} | |
| onClick={() => setIsCommandMenuOpened(true)} |
front/src/AppNavbar.tsx
Outdated
|
|
||
| import { isCommandMenuOpenedState } from '@/command-menu/states/isCommandMenuOpened'; |
There was a problem hiding this comment.
Suggested change
| import { isCommandMenuOpenedState } from '@/command-menu/states/isCommandMenuOpened'; | |
| import { isCommandMenuOpenedState } from '@/command-menu/states/isCommandMenuOpenedState'; |
charlesBochet
approved these changes
Jul 15, 2023
| @@ -43,6 +47,28 @@ export function usePeopleQuery( | |||
| }); | |||
| } | |||
|
|
|||
| export function useFilteredSearchPeopleQuery( | |||
| searchFilter: string, | |||
There was a problem hiding this comment.
could you move these 3 parameters to an object: it improves the dev experience while using the function:
{ searchFilter: string, selectedPeopleIds: Array, limit?: number }
…redSearchEntityQuery
charlesBochet
force-pushed
the
add-search-to-cmd-bar
branch
from
5ea4922 to
f1d88fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation of search in commandBar