Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 802 if no text dont show avatar #831

Merged
merged 2 commits into from
Jul 22, 2023
Merged

fix: 802 if no text dont show avatar #831

merged 2 commits into from
Jul 22, 2023

Conversation

310387
Copy link
Contributor

@310387 310387 commented Jul 22, 2023

fix for #802.
if text empty or just whitespace, dont show avatar.
802

charlesBochet
charlesBochet reviewed Jul 22, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@310387 310387 requested a review from charlesBochet July 22, 2023 23:16
@charlesBochet
Copy link
Member

charlesBochet commented Jul 22, 2023 •
edited
Loading

Thanks a lot!!

If you have some time and want to help more, we also have #801 which is related, that would be super useful!
Also: in #802, we also have the issue on companies table page when the companyName is empty

@310387
Copy link
Contributor Author

310387 commented Jul 22, 2023 •
edited
Loading

Thanks a lot!!

If you have some time and want to help more, we also have #801 which is related, that would be super useful! Also: in #802, we also have the issue on companies table page when the companyName is empty

this fix also covers company name avatar issue at empty, i can send a fix for 801 tomorrow.

@charlesBochet
Copy link
Member

You are right, my bad!

@charlesBochet charlesBochet merged commit c4468d6 into twentyhq:main Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@310387 @charlesBochet