Add try catch to command #8381
Merged
Add try catch to command #8381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added error handling to the webhook operation migration command to ensure robustness during the 0.32 version upgrade process.
- Added try-catch block in
/packages/twenty-server/src/database/commands/upgrade-version/0-32/0-32-copy-webhook-operation-into-operations-command.tsto handle workspace-level errors - Enhanced error logging with workspace ID and detailed error message for better debugging
- Ensures migration continues for remaining workspaces even if one workspace fails
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+76
to
+81
| } catch (e) { | ||
| this.logger.log( | ||
| chalk.red( | ||
| `Error when running command on workspace ${workspaceId}: ${e}`, | ||
| ), | ||
| ); |
There was a problem hiding this comment.
style: Consider using logger.error() instead of logger.log() for error conditions. Also, error object might need toString() for proper serialization.
|
|
||
| const [firstWebhookPart, lastWebhookPart] = newOpe.split('.'); | ||
| const [firstWebhookPart, lastWebhookPart] = newOpe.split('.'); |
There was a problem hiding this comment.
logic: Add null check for split() result - malformed operations could cause undefined lastWebhookPart
charlesBochet
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 0-32 command