Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing the Task/Note Target picker.
Issue
A few weeks ago, we have simplified the recordPicker logic. During this refacto, we stopped making sure the selected records were fetched.
However, the optimistic update of the activity supposed that current activityTargets are present in the selection in the picker in order to filter out the removed items.
Fix
In case we don't find the record in the picker selection, we don't filter it out (it means the user cannot have removed it)
Next step
@ijreilly I think we should put it back, as the selected records do not appear on top anymore