Fix NavigationDrawer story #9235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added mock data and GraphQL handlers to fix the NavigationDrawer story in Storybook, enabling proper state management and data display.
- Added new
favorite-folders.tswith mock data structure for testing - Added
FindManyFavoriteFoldersGraphQL mock handler ingraphqlMocks.tsto support favorite folders functionality - Updated
NavigationDrawer.stories.tsxwithObjectMetadataItemsDecoratorandPrefetchLoadedDecoratorfor state management - Added custom Recoil state decorator to initialize mock workspace member and metadata items
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+6
to
+7
| createdAt: new Date().toISOString(), | ||
| updatedAt: new Date().toISOString(), |
There was a problem hiding this comment.
style: Using new Date() directly in mock data creates non-deterministic test data. Consider using a fixed date string instead.
TakuyaKurimoto
force-pushed
the
fx-storybook
branch
from
9855428 to
29827dc
Compare
lucasbordeau
approved these changes
Dec 30, 2024
lucasbordeau
approved these changes
Dec 31, 2024
lucasbordeau
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7492
Description
This PR will fix NavigationDrawer story.
Testing