Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lab #9667

Merged
merged 40 commits into from
Jan 21, 2025
Merged

Lab #9667

merged 40 commits into from
Jan 21, 2025

Conversation

ehconitin
Copy link
Contributor

@ehconitin ehconitin commented Jan 16, 2025 •
edited
Loading

@ehconitin ehconitin self-assigned this Jan 16, 2025
@ehconitin ehconitin closed this Jan 16, 2025
@ehconitin ehconitin reopened this Jan 16, 2025
@ehconitin ehconitin changed the title Labs init part 2 :) Labs Jan 16, 2025
@ehconitin ehconitin changed the title Labs Lab Jan 16, 2025
@ehconitin ehconitin requested a review from martmull January 20, 2025 17:57
martmull
martmull reviewed Jan 21, 2025
View reviewed changes
martmull
martmull approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thank you

@ehconitin ehconitin enabled auto-merge (squash) January 21, 2025 10:45
@ehconitin ehconitin disabled auto-merge January 21, 2025 10:57
@martmull
Copy link
Contributor

Lets mock PUBLIC_FEATURE_FLAGS for testing actually

martmull
martmull approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thanks

@martmull martmull merged commit 50f36e3 into twentyhq:main Jan 21, 2025
45 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-65e367c2.json

Generated by 🚫 dangerJS against 2f5766b

@ehconitin ehconitin mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet left review comments

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@martmull martmull martmull approved these changes

@FelixMalfait FelixMalfait Awaiting requested review from FelixMalfait

Assignees

@ehconitin ehconitin

Labels
-PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehconitin @martmull @FelixMalfait @charlesBochet