[1/n]: Migrate deleteOne Rest API to use TwentyORM directly

[pacyL2K19]

This PR

• Addressing Make REST API use Twenty ORM direclty #3644
• Migrates the DELETE /rest/* endpoint to use TwentyORM
• Factorizes common middleware logic into a common module

[greptile-apps]

PR Summary

This PR introduces direct TwentyORM integration for the DELETE REST API endpoint, replacing the previous GraphQL-based implementation with a more efficient direct database access approach.

• Added new RestApiCoreServiceV2 in /packages/twenty-server/src/engine/api/rest/core/rest-api-core-v2.service.ts for direct TwentyORM operations
• Implemented RestCoreMiddleware in /packages/twenty-server/src/engine/middlewares/rest-core-middleware.ts for authentication and metadata validation
• Created CommonMiddlewareOperationsService in /packages/twenty-server/src/engine/middlewares/common/common.service.ts to share middleware logic between REST and GraphQL
• Modified RestApiCoreController to use RestApiCoreServiceV2 for DELETE operations while maintaining backward compatibility for other endpoints
• Added utility function extractObjectIdFromPath in /packages/twenty-server/src/engine/api/rest/core/utils/extract-id-from-path.utils.ts for UUID validation

_{12 file(s) reviewed, 14 comment(s)
Edit PR Review Bot Settings | Greptile}

[martmull]

Hey, very nice code and strategy. Like the way you factorized middlewares and the new rest-api-core-v2 service is a great seed for the migration
I put some comments about code standard we have at twenty and some simplification suggestions. Feel free to comment. Thank you

[prastoin]

Hello there ! Hope you're doing great
GG for this great PR
I've just reviewed the integrations tests left few comments, no big deal !
About to review main logic afterwards !
If I can provide any further information of course let me know !

[pacyL2K19]

Hello there ! Hope you're doing great GG for this great PR I've left few comments, no big deal ! If I can provide any further information of course let me know !

Thank you for the review @prastoin, great suggestions
I'll be following up on this asap tomorrow morning

[prastoin]

Second review on the logic this time !
Indeed there're some very neat refactor out there, good scoping !
Sorry for the long review, I'm available whenever you are tomorrow for peer review session if you wish to !
Please let me know, have a great evening

[FelixMalfait]

Nice!

[prastoin]

Great work ! nearly there left few nitpicks nitpicks and so on

[martmull]

We are very close 😍

[prastoin]

@greptileai trigger

[greptile-apps]

PR Summary

This PR continues the migration of REST API endpoints to use TwentyORM directly, focusing on middleware and error handling improvements.

• Added comprehensive middleware architecture in /packages/twenty-server/src/engine/middlewares/middleware.service.ts with centralized authentication and error handling
• Introduced RestApiExceptionFilter in /packages/twenty-server/src/engine/api/rest/rest-api-exception.filter.ts for consistent error handling across REST endpoints
• Added integration tests in /packages/twenty-server/test/integration/rest/suites/rest-api-core-delete.integration-spec.ts covering authentication and error cases
• Configured selective middleware application in app.module.ts using MIGRATED_REST_METHODS constant for gradual migration
• Improved request data binding with new utility in /packages/twenty-server/src/engine/middlewares/utils/bind-data-to-request-object.utils.ts

_{18 file(s) reviewed, 18 comment(s)
Edit PR Review Bot Settings | Greptile}

[martmull]

Test	Main	PacyBranch
Wrong ID	{"statusCode": 400,"messages": ["Value '-20202020-3ec3-4fe3-8997-b76aa0bfa408' is not a valid UUID"],"error": "Bad Request"}	invalid input syntax for type uuid: "-20202020-0713-40a5-8216-82802401d33e"
Wrong Token
Missing Record		Could not find any entity of type "company" matching: {"where": {"id": "20202020-0713-40a5-8216-82802401d33f"}}
Valid Id of Existing Record
Valid Id of Not Existing Record		Could not find any entity of type "company" matching: {"where": {"id": "20202020-0713-40a5-8216-82802401d33e"}}

[martmull]

@pacyL2K19
Here are the behavior differences between old delete endpoint and the new one -> #9784 (comment)
What we should do:

• return only data.deleteCompany.id (and not all the record) when delete succeed
• return a 401 status error when token invalid (and not a 500 error) (maybe an update of packages/twenty-server/src/engine/api/rest/rest-api-exception.filter.ts)
• format the error data like this

{
"statusCode": 400,
"messages": [<messages>],
"error": "Bad Request"
}

We probably need to pass the change in writeRestResponseOnExceptionCaught method

Also, I think all those cases should be tested if possible

[pacyL2K19]

@pacyL2K19 Here are the behavior differences between old delete endpoint and the new one -> #9784 (comment) What we should do:

• return only data.deleteCompany.id (and not all the record) when delete succeed
• return a 401 status error when token invalid (and not a 500 error) (maybe an update of packages/twenty-server/src/engine/api/rest/rest-api-exception.filter.ts)
• format the error data like this

{
"statusCode": 400,
"messages": [<messages>],
"error": "Bad Request"
}

We probably need to pass the change in writeRestResponseOnExceptionCaught method

Also, I think all those cases should be tested if possible

I'm on this

[pacyL2K19]

@pacyL2K19 Here are the behavior differences between old delete endpoint and the new one -> #9784 (comment) What we should do:

• return only data.deleteCompany.id (and not all the record) when delete succeed
• return a 401 status error when token invalid (and not a 500 error) (maybe an update of packages/twenty-server/src/engine/api/rest/rest-api-exception.filter.ts)
• format the error data like this

{
"statusCode": 400,
"messages": [<messages>],
"error": "Bad Request"
}

We probably need to pass the change in writeRestResponseOnExceptionCaught method
Also, I think all those cases should be tested if possible

I'm on this

This is ready for another review @martmull

[martmull]

Very nice, thank you for your outstanding work! I believe we have an excellent first PR to kickstart the migration

[github-actions]

	Fails
🚫	node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5591:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5562:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5571:7)�[39m
danger-results://tmp/danger-results-903b417b.json

Generated by 🚫 dangerJS against f2252b6

[prastoin]

Congrats @pacyL2K19 ! :) Thanks for the great code and work !