-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating SettingsAccountsListEmptyStateCard #9868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Updated the SettingsAccountsListEmptyStateCard component text from 'Connect a Google account' to 'Choose your provider' to better reflect support for multiple providers, with corresponding localization updates.
- Modified
/packages/twenty-front/src/modules/settings/accounts/components/SettingsNewAccountSection.tsx
to use more provider-agnostic label text - Added new translation entries for 'Choose your provider' in all language files (de, es, fr, it, pt, zh-Hans, zh-Hant)
- Marked old 'Connect a Google account' translations as obsolete across all localization files
- Missing translations for new text in several language files need to be added (de, es, pt, zh-Hant)
10 file(s) reviewed, 16 comment(s)
Edit PR Review Bot Settings | Greptile
#: src/modules/settings/accounts/components/SettingsNewAccountSection.tsx:13 | ||
msgid "Choose your provider" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing German translation for 'Choose your provider'
msgid "Choose your provider" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Spanish translation for 'Choose your provider'
msgid "Choose your provider" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing French translation for "Choose your provider"
#: src/modules/command-menu/components/CommandMenu.tsx:213 | ||
#: src/modules/command-menu/components/CommandMenu.tsx:213 | ||
msgid "Context" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing French translation for "Context"
msgid "Lab" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing French translation for "Lab"
#: src/modules/settings/accounts/components/SettingsNewAccountSection.tsx:13 | ||
msgid "Choose your provider" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Traditional Chinese translation for 'Choose your provider'
#~ msgid "Connect a Google account" | ||
#~ msgstr "连接 Google 账户" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Old translation marked with #~ but should be removed since the string is no longer used
msgid "Choose your provider" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Portuguese translation for 'Choose your provider'
msgid "Lab" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Portuguese translation for 'Lab'
msgid "Reset to" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Portuguese translation for 'Reset to'
Log
|
changing from "Connect a Google account" to "Choose your provider" updating all languages using `npx nx run twenty-front:lingui:extract`
changing from "Connect a Google account" to "Choose your provider"
updating all languages using
npx nx run twenty-front:lingui:extract