Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating SettingsAccountsListEmptyStateCard #9868

Merged
merged 1 commit into from
Jan 27, 2025
Merged

updating SettingsAccountsListEmptyStateCard #9868

merged 1 commit into from
Jan 27, 2025

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Jan 27, 2025

changing from "Connect a Google account" to "Choose your provider"

updating all languages using
npx nx run twenty-front:lingui:extract

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated the SettingsAccountsListEmptyStateCard component text from 'Connect a Google account' to 'Choose your provider' to better reflect support for multiple providers, with corresponding localization updates.

  • Modified /packages/twenty-front/src/modules/settings/accounts/components/SettingsNewAccountSection.tsx to use more provider-agnostic label text
  • Added new translation entries for 'Choose your provider' in all language files (de, es, fr, it, pt, zh-Hans, zh-Hant)
  • Marked old 'Connect a Google account' translations as obsolete across all localization files
  • Missing translations for new text in several language files need to be added (de, es, pt, zh-Hant)

10 file(s) reviewed, 16 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +219 to +221
#: src/modules/settings/accounts/components/SettingsNewAccountSection.tsx:13
msgid "Choose your provider"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing German translation for 'Choose your provider'

Comment on lines +220 to +221
msgid "Choose your provider"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Spanish translation for 'Choose your provider'

Comment on lines +220 to +221
msgid "Choose your provider"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing French translation for "Choose your provider"

Comment on lines +271 to +274
#: src/modules/command-menu/components/CommandMenu.tsx:213
#: src/modules/command-menu/components/CommandMenu.tsx:213
msgid "Context"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing French translation for "Context"

Comment on lines +644 to +645
msgid "Lab"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing French translation for "Lab"

Comment on lines +219 to +221
#: src/modules/settings/accounts/components/SettingsNewAccountSection.tsx:13
msgid "Choose your provider"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Traditional Chinese translation for 'Choose your provider'

Comment on lines +252 to +253
#~ msgid "Connect a Google account"
#~ msgstr "连接 Google 账户"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Old translation marked with #~ but should be removed since the string is no longer used

Comment on lines +220 to +221
msgid "Choose your provider"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Portuguese translation for 'Choose your provider'

Comment on lines +644 to +645
msgid "Lab"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Portuguese translation for 'Lab'

Comment on lines +862 to +863
msgid "Reset to"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Portuguese translation for 'Reset to'

@FelixMalfait FelixMalfait merged commit 4bb8e3a into main Jan 27, 2025
48 of 49 checks passed
@FelixMalfait FelixMalfait deleted the text-update branch January 27, 2025 14:20
Copy link
Contributor

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-27580f24.json

Generated by 🚫 dangerJS against bedbc8c

charlesBochet pushed a commit that referenced this pull request Jan 28, 2025
changing from "Connect a Google account" to  "Choose your provider"

updating all languages using 
`npx nx run twenty-front:lingui:extract`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants