Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Video Room Monitor to app #594

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Add Video Room Monitor to app #594

merged 4 commits into from
Sep 24, 2021

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Sep 22, 2021

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • N/A

Description

This PR adds a button to the menu to toggle the Video Room Monitor. The button is only visible on desktop.
image

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

olipyskoty
olipyskoty previously approved these changes Sep 22, 2021
Copy link
Contributor

@olipyskoty olipyskoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! I am almost wondering if we should reorder the menu list at some point. Not sure why, but feels slightly off to me? I almost feel like About and Settings should be moved to the bottom of the list.. kind of separating the tools from the settings? just a thought.

@timmydoza
Copy link
Contributor Author

I reordered the Menu items:
image

Copy link
Contributor

@olipyskoty olipyskoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@timmydoza timmydoza merged commit 16a4dbc into master Sep 24, 2021
@timmydoza timmydoza deleted the add-room-monitor branch September 24, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants