Add local follows | Convert some Kraken functions to Helix #240

Nickwasused · 2021-08-07T13:51:17Z

How this works

With Account:

Your Follows get imported from Twitch
You can´t unfollow someone that you followed on Twitch
Wiping follows dosen´t remove Twitch follows from the Database
You can follow new Channels from within the App
You can unfollow the Channels that you followed in the App
Follows from within the App are not synced (because Deprecation of Create and Delete Follows API Endpoints #230)

Without Account:

You can do nothing, because of Helix.
~~- You can follow new Channels from within the App~~
~~- You can unfollow the Channels that you followed in the App~~
~~- Your Channels get shown in the My Streams Tab when they are live~~

Problems with Helix

The Viewer Count of "Top Games" cannot be fetched (https://twitch.uservoice.com/forums/310213-developers/suggestions/37393114-add-viewer-and-channel-count-in-helix-games-top).
The Vod Chat cannot be fetched (https://twitch.uservoice.com/forums/310213-developers/suggestions/44063160-vod-chat-for-helix)

Showcase

With Account

Ubisoft and Bobross are Channels that got imported from Twitch

Without Account

Bob Ross is used as Showcase Channel

Problems

As mentioned in #236 when V5 is shutting down then everything is going to require an Auth Token. So you can´t make the required API requests without a Twitch Account logged in. But local follows should still be working with the new API.

Fixing

This should be closing:
#239
#230
(Maybee #81 and #124)

To-Do

~~wait for helix rewrite/support (Legacy Twitch API v5 Shutdown #236)~~ Done in 3a16848
Fix "GetTwitchUserFollows"
Fix importing Channels from Twitch

RickyM7 · 2021-08-07T15:27:37Z

This is amazing! A question, will an option be added to export/import the list of followed channels?

Btw I just tested and saw that when you are not logged in, the channels you follow remain as followed, but when you log in, the channels you followed offline disappear and if you follow any channel when you are logged in, that channel does not remain as followed (does not appear in 'Followed Streamers' or 'My Streams'). (Everything fixed in
327c723)

don´t wipe follows on logout don´t remove follows that are not imported from twitch on sync

Nickwasused · 2021-08-12T07:23:24Z

I have added basic export/import functions in acc3ac7

The follows get exported/imported to/from the Twire data folder.

RickyM7 · 2021-08-12T10:31:36Z

I have added basic export/import functions in acc3ac7

The follows get exported/imported to/from the Twire data folder.

I just tested it. Export works normally, but import doesn't work and the app even crashes sometimes when using this option.

RickyM7 · 2021-08-12T12:05:47Z

The error continues (I tested the last apk generated). I also have a suggestion, is there a way to make a popup message appear whenever we export/import channels?

time: 1628769584734 msg: java.lang.AssertionError: Could not execute method for android:onClick stacktrace: java.lang.IllegalStateException: Could not execute method for android:onClick at android.view.View$DeclaredOnClickListener.onClick(View.java:6268) at android.view.View.performClick(View.java:7448) at com.balysv.materialripple.MaterialRippleLayout$PerformClickEvent.run(MaterialRippleLayout.java:648) at com.balysv.materialripple.MaterialRippleLayout.onTouchEvent(MaterialRippleLayout.java:227) at android.view.View.dispatchTouchEvent(View.java:14309) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3112) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2785) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799) at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:488) at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1873) at android.app.Activity.dispatchTouchEvent(Activity.java:4125) at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:69) at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:69) at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:446) at android.view.View.dispatchPointerEvent(View.java:14568) at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6027) at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:5825) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5316) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5373) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5339) at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5491) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5347) at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5548) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5320) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5373) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5339) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5347) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5320) at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8091) at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8042) at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8003) at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:8214) at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:220) at android.os.MessageQueue.nativePollOnce(Native Method) at android.os.MessageQueue.next(MessageQueue.java:335) at android.os.Looper.loop(Looper.java:183) at android.app.ActivityThread.main(ActivityThread.java:7665) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:594) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) Caused by: java.lang.reflect.InvocationTargetException at java.lang.reflect.Method.invoke(Native Method) at android.view.View$DeclaredOnClickListener.onClick(View.java:6263) ... 54 more Caused by: java.lang.AssertionError at com.perflyst.twire.service.SubscriptionsDbHelper.onImport(SubscriptionsDbHelper.java:116) at com.perflyst.twire.activities.settings.SettingsGeneralActivity.onImport(SettingsGeneralActivity.java:168) ... 56 more

RickyM7 · 2021-08-12T16:58:06Z

~~Tested f2f24d8 artifact. The Import option still doesn't work.~~

time: 1628787268123 msg: java.lang.AssertionError stacktrace: java.lang.AssertionError at com.perflyst.twire.service.SubscriptionsDbHelper.onImport(SubscriptionsDbHelper.java:134) at com.perflyst.twire.activities.settings.SettingsGeneralActivity.lambda$onImport$7$SettingsGeneralActivity(SettingsGeneralActivity.java:191) at com.perflyst.twire.activities.settings.-$$Lambda$SettingsGeneralActivity$8UY9iNiS7RYCzRPXobFxZ1XwcPs.onClick(Unknown Source:2) at com.afollestad.materialdialogs.MaterialDialog.onClick(MaterialDialog.java:343) at android.view.View.performClick(View.java:7448) at android.view.View.performClickInternal(View.java:7425) at android.view.View.access$3600(View.java:810) at android.view.View$PerformClick.run(View.java:28305) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:223) at android.app.ActivityThread.main(ActivityThread.java:7665) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:594) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

Fixed in 1fe4d2f

samfundev

I haven't checked through everything, but I'm going to stop my review for now so that these initial comments can be worked on.

app/src/main/java/com/perflyst/twire/fragments/NavigationDrawerFragment.java

app/src/main/res/values/strings.xml

app/src/main/java/com/perflyst/twire/tasks/GetStreamsCountTask.java

app/src/main/java/com/perflyst/twire/misc/FollowHandler.java

app/src/main/java/com/perflyst/twire/activities/settings/SettingsGeneralActivity.java

app/src/main/java/com/perflyst/twire/activities/ChannelActivity.java

…Service"

samfundev · 2022-02-14T17:27:19Z

@Nickwasused Should I continue reviewing this or are you still working on it? Some stuff is still unresolved from the previous review.

Nickwasused · 2022-02-15T10:33:47Z

@samfundev I think you can start to review, the only thing left is to move the search to helix.

samfundev

Hopefully the last review.

app/src/main/java/com/perflyst/twire/activities/ChannelActivity.java

app/src/main/java/com/perflyst/twire/service/JSONService.java

app/src/main/java/com/perflyst/twire/tasks/HandlerUserLoginTask.java

app/src/main/java/com/perflyst/twire/activities/GameActivity.java

app/src/main/java/com/perflyst/twire/activities/main/MyChannelsActivity.java

app/src/main/java/com/perflyst/twire/activities/main/MyStreamsActivity.java

Co-authored-by: Sam <samdinner@hotmail.com>

app/src/main/java/com/perflyst/twire/activities/main/MyStreamsActivity.java

samfundev · 2022-02-16T17:07:24Z

@Nickwasused Oh wait, are you going to migrate the search to helix as well? If you want, I could do it.

Nickwasused · 2022-02-16T17:15:10Z

@samfundev It would be great if you can take a look at it.

Nickwasused added 4 commits August 7, 2021 13:38

add offline follows

8939527

don´t load streamers from twitch if not logged in

347ffde

get my follows from the DB rather than twitch

f540120

fix wrong stream count

9c6ebe9

Nickwasused added 2 commits August 7, 2021 19:16

add custom option to wipe all follows

327c723

don´t wipe follows on logout don´t remove follows that are not imported from twitch on sync

add import/export function

acc3ac7

Nickwasused added 2 commits August 12, 2021 13:38

add more checks to the import option

57debeb

fix settings layout

e23a4a4

Nickwasused added 3 commits August 12, 2021 14:37

add more info on Export/Import

3c119e8

don´t wipe twitch follows if logged in

30113e9

Update SettingsGeneralActivity.java

f2f24d8

try other file reading

1fe4d2f

fefo-dev mentioned this pull request Sep 15, 2021

VODs fail to play (because of mature audience flag?) #215

Closed

uuuussseer mentioned this pull request Nov 13, 2021

Notification When Streamer Goes Live #260

Closed

samfundev requested changes Dec 16, 2021

View reviewed changes

Nickwasused added 8 commits December 17, 2021 11:43

Merge branch 'master' into fix-follows-v2

1caac9c

remove unused code

e33e590

Removed duplicate "Cancel" String

e16f21f

correct spelling

f45b1f1

localize strings | fix file error

16694b3

change Follow Button logic

df0f06c

better boolean handling | invert condition

96e422e

loop over every channel in the Database

3a16848

This was linked to issues Dec 17, 2021

Deprecation of Create and Delete Follows API Endpoints #230

Closed

Offline feature request #239

Closed

Nickwasused added 2 commits February 11, 2022 13:55

remove unused Task: "GetFollowedLiveStreamsTask" and Service "Streams…

1afc99a

…Service"

Change Login Scopes to Helix + Change "HandleUserLoginTask" to Helix

715499c

Nickwasused linked an issue Feb 11, 2022 that may be closed by this pull request

Twitch servers not loading or dont react #307

Closed

Nickwasused self-assigned this Feb 11, 2022

Nickwasused changed the title ~~Add offline follows | Convert some Kraken functions to Helix [WIP]~~ Add offline follows | Convert all Kraken functions to Helix [WIP] Feb 11, 2022

fix follow fetcher

1a5aac4

Nickwasused changed the title ~~Add offline follows | Convert all Kraken functions to Helix [WIP]~~ Add local follows | Convert all Kraken functions to Helix [WIP] Feb 12, 2022

Fix follower fetcher

3cc7b8f

make settings dialog simpler | remove redundant toString()

0729d3f

samfundev requested changes Feb 15, 2022

View reviewed changes

Nickwasused linked an issue Feb 16, 2022 that may be closed by this pull request

Oops, Twitch's servers don't seem to be responding. Refresh? #309

Closed

Nickwasused and others added 6 commits February 16, 2022 15:45

simplify logic in HandlerUserLoginTask.java

21d3388

Co-authored-by: Sam <samdinner@hotmail.com>

Change "getVodlenght" to "getVodLenght"

43230f3

remove duplicate "&after=" in GameActivity.java

02d3715

Co-authored-by: Sam <samdinner@hotmail.com>

revert "MyChannelsActivity" 43230f3

2b53708

simplify using Guava "MyStreamsActivity.java"

622ff77

Co-authored-by: Sam <samdinner@hotmail.com>

fix Mystreams

e7dc3ed

samfundev reviewed Feb 16, 2022

View reviewed changes

app/src/main/java/com/perflyst/twire/activities/main/MyStreamsActivity.java Outdated Show resolved Hide resolved

Nickwasused added 2 commits February 16, 2022 17:37

add pagination to channel vods and highlights

4085c50

better list managment in MyStreams

c500ea5

samfundev approved these changes Feb 16, 2022

View reviewed changes

Nickwasused changed the title ~~Add local follows | Convert all Kraken functions to Helix [WIP]~~ Add local follows | Convert all Kraken functions to Helix Feb 16, 2022

Nickwasused changed the title ~~Add local follows | Convert all Kraken functions to Helix~~ Add local follows | Convert some Kraken functions to Helix Feb 16, 2022

Nickwasused merged commit 4d16976 into twireapp:master Feb 16, 2022

This was referenced Jul 2, 2022

Copy followed list / local follows #81

Closed

RSS Subscription with Export/Import #124

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add local follows | Convert some Kraken functions to Helix #240

Add local follows | Convert some Kraken functions to Helix #240

Nickwasused commented Aug 7, 2021 •

edited

Loading

RickyM7 commented Aug 7, 2021 •

edited

Loading

Nickwasused commented Aug 12, 2021 •

edited

Loading

RickyM7 commented Aug 12, 2021

RickyM7 commented Aug 12, 2021

RickyM7 commented Aug 12, 2021 •

edited

Loading

samfundev left a comment

samfundev commented Feb 14, 2022

Nickwasused commented Feb 15, 2022

samfundev left a comment

samfundev commented Feb 16, 2022 •

edited

Loading

Nickwasused commented Feb 16, 2022

Add local follows | Convert some Kraken functions to Helix #240

Add local follows | Convert some Kraken functions to Helix #240

Conversation

Nickwasused commented Aug 7, 2021 • edited Loading

How this works

Problems with Helix

Showcase

With Account

Without Account

Problems

Fixing

To-Do

RickyM7 commented Aug 7, 2021 • edited Loading

Nickwasused commented Aug 12, 2021 • edited Loading

RickyM7 commented Aug 12, 2021

RickyM7 commented Aug 12, 2021

RickyM7 commented Aug 12, 2021 • edited Loading

samfundev left a comment

Choose a reason for hiding this comment

samfundev commented Feb 14, 2022

Nickwasused commented Feb 15, 2022

samfundev left a comment

Choose a reason for hiding this comment

samfundev commented Feb 16, 2022 • edited Loading

Nickwasused commented Feb 16, 2022

Nickwasused commented Aug 7, 2021 •

edited

Loading

RickyM7 commented Aug 7, 2021 •

edited

Loading

Nickwasused commented Aug 12, 2021 •

edited

Loading

RickyM7 commented Aug 12, 2021 •

edited

Loading

samfundev commented Feb 16, 2022 •

edited

Loading