feat(settings): Add support to configure fragment types via tables

[danieljmv01]

• Add support to toml tables for custom fragments,
  with default values.

Resolves: twisted/#369
Signed-off-by: danieljmv01 danieljmv01@gmail.com

[codecov]

Codecov Report

Merging #370 (bda743b) into master (27cd970) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   96.85%   97.04%   +0.19%     
==========================================
  Files          20       22       +2     
  Lines        1241     1321      +80     
  Branches      120      126       +6     
==========================================
+ Hits         1202     1282      +80     
  Misses         20       20              
  Partials       19       19              

Impacted Files	Coverage Δ
src/towncrier/_settings/__init__.py	100.00% <100.00%> (ø)
src/towncrier/_settings/fragment_types.py	100.00% <100.00%> (ø)
src/towncrier/_settings/load.py	96.20% <100.00%> (ø)
src/towncrier/test/test_settings.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cd970...bda743b. Read the comment docs.

[adiroiban]

Many thanks for the changes.

So we can have [tool.towncrier.fragment.chores] or [tool.towncrier.fragment.feat].

I am a bit (just a bit) worried about possible future conflicts.

So, as you think is best.

We can play safe and go with the more verbose [tool.towncrier.fragment.chores] as long as this is documented, it should be fine.

[adiroiban]

I am ok with any change that makes you happy :) as long as it has tests to prevent any future regressions.

My only concern is that we should try to get it right, so that in the future we will not have to also deprecate this method :)

So, maybe play it safe and go with [tool.towncrier.fragment.chores]
It's bit more verbose, but you only define this once.
And it should be more explicit.

Thanks again

[adiroiban]

So, maybe we should go with something like this

[tool.towncrier]
package="foo"
newsfile="news.rst"

[tool.towncrier.fragment.chores]
name= "foo"

It's more verbose, but we don't risk any colision.
I am not very happy about the extra fragment_types list.

I think that if we place everything inside tool.towncrier.fragment.* they can be automatically discovered.

[danieljmv01]

So, maybe we should go with something like this

[tool.towncrier]
package="foo"
newsfile="news.rst"

[tool.towncrier.fragment.chores]
name= "foo"

It's more verbose, but we don't risk any colision. I am not very happy about the extra fragment_types list.

I think that if we place everything inside tool.towncrier.fragment.* they can be automatically discovered.

Ok, cool. I will use the keys of "tool.towncrier.fragment" mapping to get the fragments instead of using "fragment_types" array then.

[adiroiban]

Looks good. Many thanks.

I left a few minor comments.

Other than that, I think that this is ready to merge.

[adiroiban]

All good. Thanks.

let's merge this.

We need to remove the duplication of docs from README and docs/ , but that can be don in a separate PR.

Thanks!