Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out a static inner method from #769 for better GC #779

Merged
merged 1 commit into from
Jan 10, 2016

Conversation

aryairani
Copy link
Contributor

I think the existing implementation will retain a reference to the outer-most Call by referencing its cats$Eval$Call$$loop$1 member. This patch makes loop private/static instead.

@aryairani
Copy link
Contributor Author

P.S. I don't know how to test this without assuming that System.gc() will do a full GC.

@codecov-io
Copy link

Current coverage is 88.45%

Merging #779 into master will not affect coverage as of d4235dc

@@            master    #779   diff @@
======================================
  Files          166     166       
  Stmts         2287    2287       
  Branches        74      74       
  Methods          0       0       
======================================
  Hit           2023    2023       
  Partial          0       0       
  Missed         264     264       

Review entire Coverage Diff as of d4235dc

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Jan 6, 2016

I don't claim to be an expert in these matters, but I certainly don't see any harm in factoring this out to be static.

👍

@aryairani
Copy link
Contributor Author

Bump :)

@adelbertc
Copy link
Contributor

👍

adelbertc added a commit that referenced this pull request Jan 10, 2016
factor out a static inner method from #769 for better GC
@adelbertc adelbertc merged commit a64cd76 into typelevel:master Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants