Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct instantiation of attribution control #702

Closed
erictheise opened this issue Jul 7, 2024 · 1 comment
Closed

Correct instantiation of attribution control #702

erictheise opened this issue Jul 7, 2024 · 1 comment

Comments

@erictheise
Copy link
Contributor

Working on attribution strings downstream at OHM it appears that these two lines have no effect. An attribution control needs to be instantiated, then added to the map like this

const attribControl = new L.Control.Attribution({position: "bottomright"});
attribControl.addAttribution(tilesAttrib);
attribControl.addTo(ide.map);

Note that the attribution control that appears on the live site is the one created when the Leaflet map is initialized, as {prefix: false} is not honored.

tyrasd added a commit that referenced this issue Nov 3, 2024
…bution-control

Proposed fix for #702/Correct instantiation of attribution control
@tyrasd
Copy link
Owner

tyrasd commented Nov 3, 2024

should be fixed with #703, right?

@tyrasd tyrasd closed this as completed Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants