feat: new portlet definition attribute: alternativeMaximizedLinkTarget #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inkTarget' Add a new parameter `alternativeMaximizedLinkTarget` to provide the window target instead of having by default the `_blank` value on a href link. Usefull for starting using esco-content-menu outside of the portal directly on iframes and when we want that's open on `_self` target.
…et when set on sitemap
|
Hey folks I need your review on these change, and to merge it, could you watch on ? Thanks. |
|
Hi folks, the esco-content-menu will evolve with this new param, can I merge ? This is working well on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Add a new parameter
alternativeMaximizedLinkTargetto provide the window target instead of having by default the_blankvalue on a href link.Usefull when starting using esco-content-menu outside of the portal, like directly inside iframes and when we want that's open on
_selftarget (replacing uPortal page by the alternativeMaximizedLink).The default value keep the a href target="_blank".