chore: update node lts and update stylelint #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
requested review from
bjagg,
cbeach47,
cousquer,
jgribonvald,
jonathanmtran and
loulou2u
ChristianMurphy
commented
Dec 14, 2022
| @@ -30,32 +30,32 @@ | |||
| * NOTE: Do not change the location of Bootstrap sources lightly; they must | |||
| * be included in the uPortal.war package. | |||
| */ | |||
| @import "../../../../webjars/bootstrap/less/bootstrap.less"; | |||
| @import url("../../../../webjars/bootstrap/less/bootstrap.less"); | |||
There was a problem hiding this comment.
these imports appear to resolve exactly the same, but make it clearer that it is a browser path
Comment on lines
-969
to
963
| -moz-box-shadow: 0 0 4px 0 #333; | ||
| -webkit-box-shadow: 0 0 4px 0 #333; | ||
| box-shadow: 0 0 4px 0 #333; |
There was a problem hiding this comment.
these got folded together, no browser needs these prefixed anymore.
https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow
Comment on lines
-309
to
+269
| &:lastchild { | ||
| &:last-child { |
There was a problem hiding this comment.
stylelint caught this typo
| @@ -457,6 +403,7 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
stylelint adds a newline between blocks of css
bjagg
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Updates node to latest long term support release.
Update stylelint to latest version, and resolves new lint errors detected.
This should not change how the build runs, or how the page is styled.
It focuses on improving code styles and having additional long term support