Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/java version in CI #2605

Merged
merged 4 commits into from
Dec 19, 2022
Merged

fix/java version in CI #2605

merged 4 commits into from
Dec 19, 2022

Conversation

loulou2u
Copy link
Contributor

@loulou2u loulou2u commented Dec 19, 2022 •
edited by bjagg
Loading

Checklist
Description of change

@loulou2u loulou2u added the bug label Dec 19, 2022
@ChristianMurphy
Copy link
Member

ChristianMurphy commented Dec 19, 2022 •
edited
Loading

Thanks for looking into the CI error @loulou2u!

I was under the impression the code should build under Java 11, even if it isn't quite fully compatible yet.
I'd ideally like to keep it a part of CI if it isn't the root cause.

It looks like the issue has been appearing in the Java 8 build for a while https://github.com/uPortal-Project/uPortal/actions/runs/3715033479/jobs/6299708747#step:3:4
And is showing up on the CI build for this PR without Java 11 as well.

Perhaps the fix for Java 8 will resolve the issue in Java 11 as well?

ChristianMurphy
ChristianMurphy approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loulou2u!

bjagg
bjagg approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@bjagg bjagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

gradle.properties
@@ -42,7 +42,7 @@ antVersion=1.10.12
awsVersion=1.12.352
apereoPortletUtilsVersion=1.1.3
aspectjVersion=1.9.9.1
casClientVersion=3.6.4
casClientVersion=3.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking down these issues!

ChristianMurphy
ChristianMurphy approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bjagg bjagg merged commit a7936ed into uPortal-Project:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjagg bjagg bjagg approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loulou2u @ChristianMurphy @bjagg