Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job names so they can be selected as required statuses #11

Merged
merged 1 commit into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ permissions:
contents: read

jobs:
checks:
py-checks:
runs-on: ubuntu-latest
steps:
- name: Checkout working copy
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/py-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ permissions:
contents: read

jobs:
wheels:
py-test-wheels:
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down Expand Up @@ -53,8 +53,8 @@ jobs:
retention-days: 1
compression-level: 0

tests:
needs: wheels
py-tests:
needs: py-test-wheels
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/pyo3-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
contents: read

jobs:
wheels:
py-release-wheels:
strategy:
matrix:
python-version:
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
retention-days: 1
compression-level: 0

sdist:
py-release-sdist:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -90,8 +90,8 @@ jobs:
name: wheels-sdist
path: dist

tests:
needs: wheels
py-release-tests:
needs: py-release-wheels

strategy:
matrix:
Expand Down Expand Up @@ -168,10 +168,10 @@ jobs:
- name: Run tests
run: pytest -v -Werror -ra ua-parser-py

release:
py-release:
name: Release
runs-on: ubuntu-latest
needs: [tests, sdist]
needs: [py-release-tests, py-release-sdist]
if: ${{ inputs.release == 'true' }}
permissions:
# Use to sign the release artifacts
Expand Down
17 changes: 12 additions & 5 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,25 @@ env:
CARGO_TERM_COLOR: always

jobs:
checks:
rust-checks:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Check
run: cargo check
- name: Format
run: cargo fmt --check
- name: clippy
if: always()
run: cargo clippy

rust-tests:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Check
run: cargo check
- name: Run tests
run: cargo test -r --verbose